mirrors/mcphub
1
0
Fork 0
mirror of https://github.com/samanhappy/mcphub.git synced 2025-12-24 02:39:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: address review feedback for oauth refresh

Browse Source 
Co-authored-by: samanhappy <2755122+samanhappy@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-13 14:36:16 +00:00
parent b98180c870
commit 914ac36f23
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/services/mcpOAuthProvider.ts
View File

@@ -354,7 +354,7 @@ export class MCPHubOAuthProvider implements OAuthClientProvider {
// Refresh if token is expired or about to expire
const expiresAt = this.getAccessTokenExpiryMs(oauth);
const now = Date.now();
if ((expiresAt && expiresAt - now <= 60_000) || !oauth.accessToken) {
if (expiresAt && expiresAt - now <= 60_000) {
const refreshed = await this.refreshAccessTokenIfNeeded(oauth.refreshToken);
if (refreshed) {
return refreshed;
@@ -405,9 +405,16 @@ export class MCPHubOAuthProvider implements OAuthClientProvider {
this.serverConfig = updatedConfig;
}
const nextRefreshToken = tokens.refreshToken ?? refreshToken;
if (tokens.refreshToken === undefined) {
console.warn(
`Refresh response missing refresh_token for ${this.serverName}, reusing existing token`,
);
}
return {
access_token: tokens.accessToken,
refresh_token: tokens.refreshToken ?? refreshToken,
refresh_token: nextRefreshToken,
token_type: 'Bearer',
expires_in: tokens.expiresIn,
};