mirrors/mcphub
1
0
Fork 0
mirror of https://github.com/samanhappy/mcphub.git synced 2025-12-24 02:39:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: filter out empty values in tool arguments for improved functionality (#280)

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
samanhappy
2025-08-20 14:21:51 +08:00
committed by GitHub
parent 6a8f246dff
commit 81c3091a5c
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/components/ui/ToolCard.tsx
View File

@@ -14,6 +14,15 @@ interface ToolCardProps {
onDescriptionUpdate?: (toolName: string, description: string) => void
}
// Helper to check for "empty" values
function isEmptyValue(value: any): boolean {
if (value == null) return true; // null or undefined
if (typeof value === 'string') return value.trim() === '';
if (Array.isArray(value)) return value.length === 0;
if (typeof value === 'object') return Object.keys(value).length === 0;
return false;
}
const ToolCard = ({ tool, server, onToggle, onDescriptionUpdate }: ToolCardProps) => {
const { t } = useTranslation()
const [isExpanded, setIsExpanded] = useState(false)
@@ -100,6 +109,8 @@ const ToolCard = ({ tool, server, onToggle, onDescriptionUpdate }: ToolCardProps
const handleRunTool = async (arguments_: Record<string, any>) => {
setIsRunning(true)
try {
// filter empty values
arguments_ = Object.fromEntries(Object.entries(arguments_).filter(([_, v]) => !isEmptyValue(v)))
const result = await callTool({
toolName: tool.name,
arguments: arguments_,

4
frontend/src/pages/LoginPage.tsx
View File

@@ -68,9 +68,9 @@ const LoginPage: React.FC = () => {
</div>
{/* Main content */}
<div className="relative mx-auto grid min-h-screen w-full max-w-7xl grid-cols-1 items-center gap-8 px-6 py-16 md:grid-cols-3 lg:gap-16">
<div className="relative mx-auto grid min-h-screen w-full max-w-7xl grid-cols-1 items-center px-10 py-16 md:grid-cols-3">
{/* Left: brand + slogan */}
<div className="order-2 space-y-6 md:order-1 md:col-span-2">
<div className="order-2 space-y-6 md:order-1 md:col-span-2 pr-6">
<div className="inline-flex items-center gap-2 rounded-full border border-indigo-500/20 bg-indigo-500/10 px-3 py-1 text-xs font-medium text-indigo-700 shadow-sm backdrop-blur dark:text-indigo-300">
<span className="h-2 w-2 animate-pulse rounded-full bg-indigo-500" />
{t('app.name')}