fix: fix ManageSlideOver for blacklist

Try to resolve some performance issues by removing the eager loading of Blacklist items from the
Media entity

CONTRIBUTING.md

@@ -48,7 +48,7 @@ All help is welcome and greatly appreciated! If you would like to contribute to
 4. Run the development environment:
 
    ```bash
-   pnpm install
+   pnpm
    pnpm dev
    ```
 

cypress/config/settings.cypress.json

@@ -75,7 +75,6 @@
         "types": 0,
         "options": {
           "webhookUrl": "",
-          "webhookRoleId": "",
           "enableMentions": true
         }
       },

docs/extending-jellyseerr/reverse-proxy.mdx

@@ -95,8 +95,6 @@ location ^~ /jellyseerr {
     sub_filter '/api/v1' '/$app/api/v1';
     sub_filter '/login/plex/loading' '/$app/login/plex/loading';
     sub_filter '/images/' '/$app/images/';
-    sub_filter '/imageproxy/' '/$app/imageproxy/';
-    sub_filter '/avatarproxy/' '/$app/avatarproxy/';
     sub_filter '/android-' '/$app/android-';
     sub_filter '/apple-' '/$app/apple-';
     sub_filter '/favicon' '/$app/favicon';

docs/using-jellyseerr/notifications/discord.md

@@ -18,10 +18,6 @@ Users can optionally opt-in to being mentioned in Discord notifications by confi
 
 You can find the webhook URL in the Discord application, at **Server Settings → Integrations → Webhooks**.
 
-### Notification Role ID (optional)
-
-If a role ID is specified, it will be included in the webhook message. See [Discord role ID](https://support.discord.com/hc/en-us/articles/206346498-Where-can-I-find-my-User-Server-Message-ID).
-
 ### Bot Username (optional)
 
 If you would like to override the name you configured for your bot in Discord, you may set this value to whatever you like!

next.config.js

@@ -10,7 +10,6 @@ module.exports = {
     remotePatterns: [
       { hostname: 'gravatar.com' },
       { hostname: 'image.tmdb.org' },
-      { hostname: 'artworks.thetvdb.com' },
     ],
   },
   webpack(config) {

overseerr-api.yml

@@ -1273,8 +1273,6 @@ components:
               type: string
             webhookUrl:
               type: string
-            webhookRoleId:
-              type: string
             enableMentions:
               type: boolean
     SlackSettings:
@@ -1932,11 +1930,6 @@ components:
           type: string
         native_name:
           type: string
-    OverrideRule:
-      type: object
-      properties:
-        id:
-          type: string
   securitySchemes:
     cookieAuth:
       type: apiKey
@@ -3760,11 +3753,6 @@ paths:
             type: string
             enum: [created, updated, requests, displayname]
             default: created
-        - in: query
-          name: q
-          required: false
-          schema:
-            type: string
       responses:
         '200':
           description: A JSON array of all users
@@ -6966,68 +6954,6 @@ paths:
                 type: array
                 items:
                   $ref: '#/components/schemas/WatchProviderDetails'
-  /overrideRule:
-    get:
-      summary: Get override rules
-      description: Returns a list of all override rules with their conditions and settings
-      tags:
-        - overriderule
-      responses:
-        '200':
-          description: Override rules returned
-          content:
-            application/json:
-              schema:
-                type: array
-                items:
-                  $ref: '#/components/schemas/OverrideRule'
-    post:
-      summary: Create override rule
-      description: Creates a new Override Rule from the request body.
-      tags:
-        - overriderule
-      responses:
-        '200':
-          description: 'Values were successfully created'
-          content:
-            application/json:
-              schema:
-                type: array
-                items:
-                  $ref: '#/components/schemas/OverrideRule'
-  /overrideRule/{ruleId}:
-    put:
-      summary: Update override rule
-      description: Updates an Override Rule from the request body.
-      tags:
-        - overriderule
-      responses:
-        '200':
-          description: 'Values were successfully updated'
-          content:
-            application/json:
-              schema:
-                type: array
-                items:
-                  $ref: '#/components/schemas/OverrideRule'
-    delete:
-      summary: Delete override rule by ID
-      description: Deletes the override rule with the provided ruleId.
-      tags:
-        - overriderule
-      parameters:
-        - in: path
-          name: ruleId
-          required: true
-          schema:
-            type: number
-      responses:
-        '200':
-          description: Override rule successfully deleted
-          content:
-            application/json:
-              schema:
-                $ref: '#/components/schemas/OverrideRule'
 security:
   - cookieAuth: []
   - apiKey: []

server/api/jellyfin.ts

@@ -138,38 +138,39 @@ class JellyfinAPI extends ExternalAPI {
     try {
       return await authenticate(true);
     } catch (e) {
-      logger.debug('Failed to authenticate with headers', {
+      logger.debug(`Failed to authenticate with headers: ${e.message}`, {
         label: 'Jellyfin API',
-        error: e.cause.message ?? e.cause.statusText,
         ip: ClientIP,
       });
-
-      if (!e.cause.status) {
-        throw new ApiError(404, ApiErrorCode.InvalidUrl);
-      }
-
-      if (e.cause.status === 401) {
-        throw new ApiError(e.cause.status, ApiErrorCode.InvalidCredentials);
-      }
     }
 
     try {
       return await authenticate(false);
     } catch (e) {
-      if (e.cause.status === 401) {
-        throw new ApiError(e.cause.status, ApiErrorCode.InvalidCredentials);
+      const status = e.cause?.status;
+
+      const networkErrorCodes = new Set([
+        'ECONNREFUSED',
+        'EHOSTUNREACH',
+        'ENOTFOUND',
+        'ETIMEDOUT',
+        'ECONNRESET',
+        'EADDRINUSE',
+        'ENETDOWN',
+        'ENETUNREACH',
+        'EPIPE',
+        'ECONNABORTED',
+        'EPROTO',
+        'EHOSTDOWN',
+        'EAI_AGAIN',
+        'ERR_INVALID_URL',
+      ]);
+
+      if (networkErrorCodes.has(e.code) || status === 404) {
+        throw new ApiError(status, ApiErrorCode.InvalidUrl);
       }
 
-      logger.error(
-        'Something went wrong while authenticating with the Jellyfin server',
-        {
-          label: 'Jellyfin API',
-          error: e.cause.message ?? e.cause.statusText,
-          ip: ClientIP,
-        }
-      );
-
-      throw new ApiError(e.cause.status, ApiErrorCode.Unknown);
+      throw new ApiError(status, ApiErrorCode.InvalidCredentials);
     }
   }
 
@@ -197,8 +198,8 @@ class JellyfinAPI extends ExternalAPI {
       return serverResponse.ServerName;
     } catch (e) {
       logger.error(
-        'Something went wrong while getting the server name from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting the server name from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.Unknown);
@@ -212,8 +213,8 @@ class JellyfinAPI extends ExternalAPI {
       return { users: userReponse };
     } catch (e) {
       logger.error(
-        'Something went wrong while getting the account from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting the account from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -228,8 +229,8 @@ class JellyfinAPI extends ExternalAPI {
       return userReponse;
     } catch (e) {
       logger.error(
-        'Something went wrong while getting the account from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting the account from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -252,11 +253,8 @@ class JellyfinAPI extends ExternalAPI {
         return this.mapLibraries(mediaFolderResponse.Items);
       } catch (e) {
         logger.error(
-          'Something went wrong while getting libraries from the Jellyfin server',
-          {
-            label: 'Jellyfin API',
-            error: e.cause.message ?? e.cause.statusText,
-          }
+          `Something went wrong while getting libraries from the Jellyfin server: ${e.message}`,
+          { label: 'Jellyfin API' }
         );
 
         return [];
@@ -310,8 +308,8 @@ class JellyfinAPI extends ExternalAPI {
       );
     } catch (e) {
       logger.error(
-        'Something went wrong while getting library content from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting library content from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -331,8 +329,8 @@ class JellyfinAPI extends ExternalAPI {
       return itemResponse;
     } catch (e) {
       logger.error(
-        'Something went wrong while getting library content from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting library content from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -356,8 +354,8 @@ class JellyfinAPI extends ExternalAPI {
       }
 
       logger.error(
-        'Something went wrong while getting library content from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting library content from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
     }
@@ -370,8 +368,8 @@ class JellyfinAPI extends ExternalAPI {
       return seasonResponse.Items;
     } catch (e) {
       logger.error(
-        'Something went wrong while getting the list of seasons from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting the list of seasons from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -395,8 +393,8 @@ class JellyfinAPI extends ExternalAPI {
       );
     } catch (e) {
       logger.error(
-        'Something went wrong while getting the list of episodes from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while getting the list of episodes from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.cause?.status, ApiErrorCode.InvalidAuthToken);
@@ -412,8 +410,8 @@ class JellyfinAPI extends ExternalAPI {
       ).AccessToken;
     } catch (e) {
       logger.error(
-        'Something went wrong while creating an API key from the Jellyfin server',
-        { label: 'Jellyfin API', error: e.cause.message ?? e.cause.statusText }
+        `Something went wrong while creating an API key from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
       );
 
       throw new ApiError(e.response?.status, ApiErrorCode.InvalidAuthToken);

server/entity/MediaRequest.ts

@@ -13,7 +13,6 @@ import {
   MediaType,
 } from '@server/constants/media';
 import { getRepository } from '@server/datasource';
-import OverrideRule from '@server/entity/OverrideRule';
 import type { MediaRequestBody } from '@server/interfaces/api/requestInterfaces';
 import notificationManager, { Notification } from '@server/lib/notifications';
 import { Permission } from '@server/lib/permissions';
@@ -714,6 +713,48 @@ export class MediaRequest {
           return;
         }
 
+        let rootFolder = radarrSettings.activeDirectory;
+        let qualityProfile = radarrSettings.activeProfileId;
+        let tags = radarrSettings.tags ? [...radarrSettings.tags] : [];
+
+        if (
+          this.rootFolder &&
+          this.rootFolder !== '' &&
+          this.rootFolder !== radarrSettings.activeDirectory
+        ) {
+          rootFolder = this.rootFolder;
+          logger.info(`Request has an override root folder: ${rootFolder}`, {
+            label: 'Media Request',
+            requestId: this.id,
+            mediaId: this.media.id,
+          });
+        }
+
+        if (
+          this.profileId &&
+          this.profileId !== radarrSettings.activeProfileId
+        ) {
+          qualityProfile = this.profileId;
+          logger.info(
+            `Request has an override quality profile ID: ${qualityProfile}`,
+            {
+              label: 'Media Request',
+              requestId: this.id,
+              mediaId: this.media.id,
+            }
+          );
+        }
+
+        if (this.tags && !isEqual(this.tags, radarrSettings.tags)) {
+          tags = this.tags;
+          logger.info(`Request has override tags`, {
+            label: 'Media Request',
+            requestId: this.id,
+            mediaId: this.media.id,
+            tagIds: tags,
+          });
+        }
+
         const tmdb = new TheMovieDb();
         const radarr = new RadarrAPI({
           apiKey: radarrSettings.apiKey,
@@ -734,151 +775,6 @@ export class MediaRequest {
           return;
         }
 
-        let rootFolder = radarrSettings.activeDirectory;
-        let qualityProfile = radarrSettings.activeProfileId;
-        let tags = radarrSettings.tags ? [...radarrSettings.tags] : [];
-
-        const overrideRuleRepository = getRepository(OverrideRule);
-        const overrideRules = await overrideRuleRepository.find({
-          where: { radarrServiceId: radarrSettings.id },
-        });
-        const appliedOverrideRules = overrideRules.filter((rule) => {
-          if (
-            rule.users &&
-            !rule.users
-              .split(',')
-              .some((userId) => Number(userId) === this.requestedBy.id)
-          ) {
-            return false;
-          }
-          if (
-            rule.genre &&
-            !rule.genre
-              .split(',')
-              .some((genreId) =>
-                movie.genres.map((genre) => genre.id).includes(Number(genreId))
-              )
-          ) {
-            return false;
-          }
-          if (
-            rule.language &&
-            !rule.language
-              .split('|')
-              .some((languageId) => languageId === movie.original_language)
-          ) {
-            return false;
-          }
-          if (
-            rule.keywords &&
-            !rule.keywords
-              .split(',')
-              .some((keywordId) =>
-                movie.keywords.keywords
-                  .map((keyword) => keyword.id)
-                  .includes(Number(keywordId))
-              )
-          ) {
-            return false;
-          }
-          return true;
-        });
-
-        if (
-          this.rootFolder &&
-          this.rootFolder !== '' &&
-          this.rootFolder !== radarrSettings.activeDirectory
-        ) {
-          rootFolder = this.rootFolder;
-          logger.info(
-            `Request has a manually overriden root folder: ${rootFolder}`,
-            {
-              label: 'Media Request',
-              requestId: this.id,
-              mediaId: this.media.id,
-            }
-          );
-        } else {
-          const overrideRootFolder = appliedOverrideRules.find(
-            (rule) => rule.rootFolder
-          )?.rootFolder;
-          if (overrideRootFolder) {
-            rootFolder = overrideRootFolder;
-            this.rootFolder = rootFolder;
-            logger.info(
-              `Request has an override root folder from override rules: ${rootFolder}`,
-              {
-                label: 'Media Request',
-                requestId: this.id,
-                mediaId: this.media.id,
-              }
-            );
-          }
-        }
-
-        if (
-          this.profileId &&
-          this.profileId !== radarrSettings.activeProfileId
-        ) {
-          qualityProfile = this.profileId;
-          logger.info(
-            `Request has a manually overriden quality profile ID: ${qualityProfile}`,
-            {
-              label: 'Media Request',
-              requestId: this.id,
-              mediaId: this.media.id,
-            }
-          );
-        } else {
-          const overrideProfileId = appliedOverrideRules.find(
-            (rule) => rule.profileId
-          )?.profileId;
-          if (overrideProfileId) {
-            qualityProfile = overrideProfileId;
-            this.profileId = qualityProfile;
-            logger.info(
-              `Request has an override quality profile ID from override rules: ${qualityProfile}`,
-              {
-                label: 'Media Request',
-                requestId: this.id,
-                mediaId: this.media.id,
-              }
-            );
-          }
-        }
-
-        if (this.tags && !isEqual(this.tags, radarrSettings.tags)) {
-          tags = this.tags;
-          logger.info(`Request has manually overriden tags`, {
-            label: 'Media Request',
-            requestId: this.id,
-            mediaId: this.media.id,
-            tagIds: tags,
-          });
-        } else {
-          const overrideTags = appliedOverrideRules.find(
-            (rule) => rule.tags
-          )?.tags;
-          if (overrideTags) {
-            tags = [
-              ...new Set([
-                ...tags,
-                ...overrideTags.split(',').map((tag) => Number(tag)),
-              ]),
-            ];
-            this.tags = tags;
-            logger.info(`Request has override tags from override rules`, {
-              label: 'Media Request',
-              requestId: this.id,
-              mediaId: this.media.id,
-              tagIds: tags,
-            });
-          }
-        }
-
-        const requestRepository = getRepository(MediaRequest);
-        requestRepository.save(this);
-
         if (radarrSettings.tagRequests) {
           let userTag = (await radarr.getTags()).find((v) =>
             v.label.startsWith(this.requestedBy.id + ' - ')
@@ -920,6 +816,7 @@ export class MediaRequest {
             mediaId: this.media.id,
           });
 
+          const requestRepository = getRepository(MediaRequest);
           this.status = MediaRequestStatus.APPROVED;
           await requestRepository.save(this);
           return;
@@ -959,6 +856,8 @@ export class MediaRequest {
             await mediaRepository.save(media);
           })
           .catch(async () => {
+            const requestRepository = getRepository(MediaRequest);
+
             this.status = MediaRequestStatus.FAILED;
             requestRepository.save(this);
 
@@ -1058,7 +957,6 @@ export class MediaRequest {
           throw new Error('Media data not found');
         }
 
-        const requestRepository = getRepository(MediaRequest);
         if (
           media[this.is4k ? 'status4k' : 'status'] === MediaStatus.AVAILABLE
         ) {
@@ -1068,6 +966,7 @@ export class MediaRequest {
             mediaId: this.media.id,
           });
 
+          const requestRepository = getRepository(MediaRequest);
           this.status = MediaRequestStatus.APPROVED;
           await requestRepository.save(this);
           return;
@@ -1082,6 +981,7 @@ export class MediaRequest {
         const tvdbId = series.external_ids.tvdb_id ?? media.tvdbId;
 
         if (!tvdbId) {
+          const requestRepository = getRepository(MediaRequest);
           await mediaRepository.remove(media);
           await requestRepository.remove(this);
           throw new Error('TVDB ID not found');
@@ -1119,110 +1019,29 @@ export class MediaRequest {
             ? [...sonarrSettings.tags]
             : [];
 
-        const overrideRuleRepository = getRepository(OverrideRule);
-        const overrideRules = await overrideRuleRepository.find({
-          where: { sonarrServiceId: sonarrSettings.id },
-        });
-        const appliedOverrideRules = overrideRules.filter((rule) => {
-          if (
-            rule.users &&
-            !rule.users
-              .split(',')
-              .some((userId) => Number(userId) === this.requestedBy.id)
-          ) {
-            return false;
-          }
-          if (
-            rule.genre &&
-            !rule.genre
-              .split(',')
-              .some((genreId) =>
-                series.genres.map((genre) => genre.id).includes(Number(genreId))
-              )
-          ) {
-            return false;
-          }
-          if (
-            rule.language &&
-            !rule.language
-              .split('|')
-              .some((languageId) => languageId === series.original_language)
-          ) {
-            return false;
-          }
-          if (
-            rule.keywords &&
-            !rule.keywords
-              .split(',')
-              .some((keywordId) =>
-                series.keywords.results
-                  .map((keyword) => keyword.id)
-                  .includes(Number(keywordId))
-              )
-          ) {
-            return false;
-          }
-          return true;
-        });
-
         if (
           this.rootFolder &&
           this.rootFolder !== '' &&
           this.rootFolder !== rootFolder
         ) {
           rootFolder = this.rootFolder;
-          logger.info(
-            `Request has a manually overriden root folder: ${rootFolder}`,
-            {
-              label: 'Media Request',
-              requestId: this.id,
-              mediaId: this.media.id,
-            }
-          );
-        } else {
-          const overrideRootFolder = appliedOverrideRules.find(
-            (rule) => rule.rootFolder
-          )?.rootFolder;
-          if (overrideRootFolder) {
-            rootFolder = overrideRootFolder;
-            this.rootFolder = rootFolder;
-            logger.info(
-              `Request has an override root folder from override rules: ${rootFolder}`,
-              {
-                label: 'Media Request',
-                requestId: this.id,
-                mediaId: this.media.id,
-              }
-            );
-          }
+          logger.info(`Request has an override root folder: ${rootFolder}`, {
+            label: 'Media Request',
+            requestId: this.id,
+            mediaId: this.media.id,
+          });
         }
 
         if (this.profileId && this.profileId !== qualityProfile) {
           qualityProfile = this.profileId;
           logger.info(
-            `Request has a manually overriden quality profile ID: ${qualityProfile}`,
+            `Request has an override quality profile ID: ${qualityProfile}`,
             {
               label: 'Media Request',
               requestId: this.id,
               mediaId: this.media.id,
             }
           );
-        } else {
-          const overrideProfileId = appliedOverrideRules.find(
-            (rule) => rule.profileId
-          )?.profileId;
-          if (overrideProfileId) {
-            qualityProfile = overrideProfileId;
-            this.profileId = qualityProfile;
-            logger.info(
-              `Request has an override quality profile ID from override rules: ${qualityProfile}`,
-              {
-                label: 'Media Request',
-                requestId: this.id,
-                mediaId: this.media.id,
-              }
-            );
-          }
         }
 
         if (
@@ -1242,31 +1061,12 @@ export class MediaRequest {
 
         if (this.tags && !isEqual(this.tags, tags)) {
           tags = this.tags;
-          logger.info(`Request has manually overriden tags`, {
+          logger.info(`Request has override tags`, {
             label: 'Media Request',
             requestId: this.id,
             mediaId: this.media.id,
             tagIds: tags,
           });
-        } else {
-          const overrideTags = appliedOverrideRules.find(
-            (rule) => rule.tags
-          )?.tags;
-          if (overrideTags) {
-            tags = [
-              ...new Set([
-                ...tags,
-                ...overrideTags.split(',').map((tag) => Number(tag)),
-              ]),
-            ];
-            this.tags = tags;
-            logger.info(`Request has override tags from override rules`, {
-              label: 'Media Request',
-              requestId: this.id,
-              mediaId: this.media.id,
-              tagIds: tags,
-            });
-          }
         }
 
         if (sonarrSettings.tagRequests) {
@@ -1301,8 +1101,6 @@ export class MediaRequest {
           }
         }
 
-        requestRepository.save(this);
-
         const sonarrSeriesOptions: AddSeriesOptions = {
           profileId: qualityProfile,
           languageProfileId: languageProfile,
@@ -1339,6 +1137,8 @@ export class MediaRequest {
             await mediaRepository.save(media);
           })
           .catch(async () => {
+            const requestRepository = getRepository(MediaRequest);
+
             this.status = MediaRequestStatus.FAILED;
             requestRepository.save(this);
 

server/entity/OverrideRule.ts

@@ -1,52 +0,0 @@
-import {
-  Column,
-  CreateDateColumn,
-  Entity,
-  PrimaryGeneratedColumn,
-  UpdateDateColumn,
-} from 'typeorm';
-
-@Entity()
-class OverrideRule {
-  @PrimaryGeneratedColumn()
-  public id: number;
-
-  @Column({ type: 'int', nullable: true })
-  public radarrServiceId?: number;
-
-  @Column({ type: 'int', nullable: true })
-  public sonarrServiceId?: number;
-
-  @Column({ nullable: true })
-  public users?: string;
-
-  @Column({ nullable: true })
-  public genre?: string;
-
-  @Column({ nullable: true })
-  public language?: string;
-
-  @Column({ nullable: true })
-  public keywords?: string;
-
-  @Column({ type: 'int', nullable: true })
-  public profileId?: number;
-
-  @Column({ nullable: true })
-  public rootFolder?: string;
-
-  @Column({ nullable: true })
-  public tags?: string;
-
-  @CreateDateColumn()
-  public createdAt: Date;
-
-  @UpdateDateColumn()
-  public updatedAt: Date;
-
-  constructor(init?: Partial<OverrideRule>) {
-    Object.assign(this, init);
-  }
-}
-
-export default OverrideRule;

server/interfaces/api/overrideRuleInterfaces.ts

@@ -1,3 +0,0 @@
-import type OverrideRule from '@server/entity/OverrideRule';
-
-export type OverrideRuleResultsResponse = OverrideRule[];

server/lib/notifications/agents/discord.ts

@@ -291,10 +291,6 @@ class DiscordAgent
         }
       }
 
-      if (settings.options.webhookRoleId) {
-        userMentions.push(`<@&${settings.options.webhookRoleId}>`);
-      }
-
       const response = await fetch(settings.options.webhookUrl, {
         method: 'POST',
         headers: {

server/lib/settings/index.ts

@@ -76,7 +76,6 @@ export interface DVRSettings {
   syncEnabled: boolean;
   preventSearch: boolean;
   tagRequests: boolean;
-  overrideRule: number[];
 }
 
 export interface RadarrSettings extends DVRSettings {
@@ -171,7 +170,6 @@ export interface NotificationAgentDiscord extends NotificationAgentConfig {
     botUsername?: string;
     botAvatarUrl?: string;
     webhookUrl: string;
-    webhookRoleId?: string;
     enableMentions: boolean;
   };
 }
@@ -396,7 +394,6 @@ class Settings {
             types: 0,
             options: {
               webhookUrl: '',
-              webhookRoleId: '',
               enableMentions: true,
             },
           },

server/migration/1731963944025-AddOverrideRules.ts

@@ -1,15 +0,0 @@
-import type { MigrationInterface, QueryRunner } from 'typeorm';
-
-export class AddOverrideRules1731963944025 implements MigrationInterface {
-  name = 'AddOverrideRules1731963944025';
-
-  public async up(queryRunner: QueryRunner): Promise<void> {
-    await queryRunner.query(
-      `CREATE TABLE "override_rule" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "radarrServiceId" integer, "sonarrServiceId" integer, "users" varchar, "genre" varchar, "language" varchar, "keywords" varchar, "profileId" integer, "rootFolder" varchar, "tags" varchar, "createdAt" datetime NOT NULL DEFAULT (datetime('now')), "updatedAt" datetime NOT NULL DEFAULT (datetime('now')))`
-    );
-  }
-
-  public async down(queryRunner: QueryRunner): Promise<void> {
-    await queryRunner.query(`DROP TABLE "override_rule"`);
-  }
-}

server/routes/blacklist.ts

@@ -7,6 +7,7 @@ import { Permission } from '@server/lib/permissions';
 import logger from '@server/logger';
 import { isAuthenticated } from '@server/middleware/auth';
 import { Router } from 'express';
+import rateLimit from 'express-rate-limit';
 import { EntityNotFoundError, QueryFailedError } from 'typeorm';
 import { z } from 'zod';
 
@@ -24,6 +25,7 @@ blacklistRoutes.get(
   isAuthenticated([Permission.MANAGE_BLACKLIST, Permission.VIEW_BLACKLIST], {
     type: 'or',
   }),
+  rateLimit({ windowMs: 60 * 1000, max: 50 }),
   async (req, res, next) => {
     const pageSize = req.query.take ? Number(req.query.take) : 25;
     const skip = req.query.skip ? Number(req.query.skip) : 0;

server/routes/index.ts

@@ -15,7 +15,6 @@ import { checkUser, isAuthenticated } from '@server/middleware/auth';
 import { mapWatchProviderDetails } from '@server/models/common';
 import { mapProductionCompany } from '@server/models/Movie';
 import { mapNetwork } from '@server/models/Tv';
-import overrideRuleRoutes from '@server/routes/overrideRule';
 import settingsRoutes from '@server/routes/settings';
 import watchlistRoutes from '@server/routes/watchlist';
 import {
@@ -161,11 +160,6 @@ router.use('/service', isAuthenticated(), serviceRoutes);
 router.use('/issue', isAuthenticated(), issueRoutes);
 router.use('/issueComment', isAuthenticated(), issueCommentRoutes);
 router.use('/auth', authRoutes);
-router.use(
-  '/overrideRule',
-  isAuthenticated(Permission.ADMIN),
-  overrideRuleRoutes
-);
 
 router.get('/regions', isAuthenticated(), async (req, res, next) => {
   const tmdb = new TheMovieDb();

server/routes/overrideRule.ts

@@ -1,136 +0,0 @@
-import { getRepository } from '@server/datasource';
-import OverrideRule from '@server/entity/OverrideRule';
-import type { OverrideRuleResultsResponse } from '@server/interfaces/api/overrideRuleInterfaces';
-import { Permission } from '@server/lib/permissions';
-import { isAuthenticated } from '@server/middleware/auth';
-import { Router } from 'express';
-
-const overrideRuleRoutes = Router();
-
-overrideRuleRoutes.get(
-  '/',
-  isAuthenticated(Permission.ADMIN),
-  async (req, res, next) => {
-    const overrideRuleRepository = getRepository(OverrideRule);
-
-    try {
-      const rules = await overrideRuleRepository.find({});
-
-      return res.status(200).json(rules as OverrideRuleResultsResponse);
-    } catch (e) {
-      next({ status: 404, message: e.message });
-    }
-  }
-);
-
-overrideRuleRoutes.post<
-  Record<string, string>,
-  OverrideRule,
-  {
-    users?: string;
-    genre?: string;
-    language?: string;
-    keywords?: string;
-    profileId?: number;
-    rootFolder?: string;
-    tags?: string;
-    radarrServiceId?: number;
-    sonarrServiceId?: number;
-  }
->('/', isAuthenticated(Permission.ADMIN), async (req, res, next) => {
-  const overrideRuleRepository = getRepository(OverrideRule);
-
-  try {
-    const rule = new OverrideRule({
-      users: req.body.users,
-      genre: req.body.genre,
-      language: req.body.language,
-      keywords: req.body.keywords,
-      profileId: req.body.profileId,
-      rootFolder: req.body.rootFolder,
-      tags: req.body.tags,
-      radarrServiceId: req.body.radarrServiceId,
-      sonarrServiceId: req.body.sonarrServiceId,
-    });
-
-    const newRule = await overrideRuleRepository.save(rule);
-
-    return res.status(200).json(newRule);
-  } catch (e) {
-    next({ status: 404, message: e.message });
-  }
-});
-
-overrideRuleRoutes.put<
-  { ruleId: string },
-  OverrideRule,
-  {
-    users?: string;
-    genre?: string;
-    language?: string;
-    keywords?: string;
-    profileId?: number;
-    rootFolder?: string;
-    tags?: string;
-    radarrServiceId?: number;
-    sonarrServiceId?: number;
-  }
->('/:ruleId', isAuthenticated(Permission.ADMIN), async (req, res, next) => {
-  const overrideRuleRepository = getRepository(OverrideRule);
-
-  try {
-    const rule = await overrideRuleRepository.findOne({
-      where: {
-        id: Number(req.params.ruleId),
-      },
-    });
-
-    if (!rule) {
-      return next({ status: 404, message: 'Override Rule not found.' });
-    }
-
-    rule.users = req.body.users;
-    rule.genre = req.body.genre;
-    rule.language = req.body.language;
-    rule.keywords = req.body.keywords;
-    rule.profileId = req.body.profileId;
-    rule.rootFolder = req.body.rootFolder;
-    rule.tags = req.body.tags;
-    rule.radarrServiceId = req.body.radarrServiceId;
-    rule.sonarrServiceId = req.body.sonarrServiceId;
-
-    const newRule = await overrideRuleRepository.save(rule);
-
-    return res.status(200).json(newRule);
-  } catch (e) {
-    next({ status: 404, message: e.message });
-  }
-});
-
-overrideRuleRoutes.delete<{ ruleId: string }, OverrideRule>(
-  '/:ruleId',
-  isAuthenticated(Permission.ADMIN),
-  async (req, res, next) => {
-    const overrideRuleRepository = getRepository(OverrideRule);
-
-    try {
-      const rule = await overrideRuleRepository.findOne({
-        where: {
-          id: Number(req.params.ruleId),
-        },
-      });
-
-      if (!rule) {
-        return next({ status: 404, message: 'Override Rule not found.' });
-      }
-
-      await overrideRuleRepository.remove(rule);
-
-      return res.status(200).json(rule);
-    } catch (e) {
-      next({ status: 404, message: e.message });
-    }
-  }
-);
-
-export default overrideRuleRoutes;

server/routes/user/index.ts

@@ -34,16 +34,8 @@ router.get('/', async (req, res, next) => {
   try {
     const pageSize = req.query.take ? Number(req.query.take) : 10;
     const skip = req.query.skip ? Number(req.query.skip) : 0;
-    const q = req.query.q ? req.query.q.toString().toLowerCase() : '';
     let query = getRepository(User).createQueryBuilder('user');
 
-    if (q) {
-      query = query.where(
-        'LOWER(user.username) LIKE :q OR LOWER(user.email) LIKE :q OR LOWER(user.plexUsername) LIKE :q OR LOWER(user.jellyfinUsername) LIKE :q',
-        { q: `%${q}%` }
-      );
-    }
-
     switch (req.query.sort) {
       case 'updated':
         query = query.orderBy('user.updatedAt', 'DESC');

server/routes/user/usersettings.ts

@@ -1,5 +1,4 @@
 import { ApiErrorCode } from '@server/constants/error';
-import { UserType } from '@server/constants/user';
 import { getRepository } from '@server/datasource';
 import { User } from '@server/entity/User';
 import { UserSettings } from '@server/entity/UserSettings';
@@ -100,29 +99,11 @@ userSettingsRoutes.post<
       });
     }
 
-    const oldEmail = user.email;
-    const oldUsername = user.username;
     user.username = req.body.username;
+    const oldEmail = user.email;
     if (user.jellyfinUsername) {
       user.email = req.body.email || user.jellyfinUsername || user.email;
     }
-    // Edge case for local users, because they have no Jellyfin username to fall back on
-    // if the email is not provided
-    if (user.userType === UserType.LOCAL) {
-      if (req.body.email) {
-        user.email = req.body.email;
-        if (
-          !user.username &&
-          user.email !== oldEmail &&
-          !oldEmail.includes('@')
-        ) {
-          user.username = oldEmail;
-        }
-      } else if (req.body.username) {
-        user.email = oldUsername || user.email;
-        user.username = req.body.username;
-      }
-    }
 
     const existingUser = await userRepository.findOne({
       where: { email: user.email },

src/components/BlacklistModal/index.tsx

@@ -38,7 +38,7 @@ const BlacklistModal = ({
   const intl = useIntl();
 
   const { data, error } = useSWR<TvDetails | MovieDetails>(
-    show ? `/api/v1/${type}/${tmdbId}` : null
+    `/api/v1/${type}/${tmdbId}`
   );
 
   return (

src/components/Common/Modal/index.tsx

@@ -7,7 +7,7 @@ import { useLockBodyScroll } from '@app/hooks/useLockBodyScroll';
 import globalMessages from '@app/i18n/globalMessages';
 import { Transition } from '@headlessui/react';
 import type { MouseEvent } from 'react';
-import React, { Fragment, useEffect, useRef } from 'react';
+import React, { Fragment, useRef } from 'react';
 import ReactDOM from 'react-dom';
 import { useIntl } from 'react-intl';
 
@@ -66,12 +66,8 @@ const Modal = React.forwardRef<HTMLDivElement, ModalProps>(
   ) => {
     const intl = useIntl();
     const modalRef = useRef<HTMLDivElement>(null);
-    const backgroundClickableRef = useRef(backgroundClickable); // This ref is used to detect state change inside the useClickOutside hook
-    useEffect(() => {
-      backgroundClickableRef.current = backgroundClickable;
-    }, [backgroundClickable]);
     useClickOutside(modalRef, () => {
-      if (onCancel && backgroundClickableRef.current) {
+      if (onCancel && backgroundClickable) {
         onCancel();
       }
     });

src/components/Discover/DiscoverTvUpcoming.tsx

@@ -7,9 +7,7 @@ import defineMessages from '@app/utils/defineMessages';
 import type { TvResult } from '@server/models/Search';
 import { useIntl } from 'react-intl';
 
-const messages = defineMessages('components.DiscoverTvUpcoming', {
-  upcomingtv: 'Upcoming Series',
-});
+const messages = defineMessages('components.DiscoverTvUpcoming', {});
 
 const DiscoverTvUpcoming = () => {
   const intl = useIntl();

src/components/Login/JellyfinLogin.tsx

@@ -82,17 +82,10 @@ const JellyfinLogin: React.FC<JellyfinLoginProps> = ({
       port: Yup.number().required(
         intl.formatMessage(messages.validationPortRequired)
       ),
-      urlBase: Yup.string()
-        .test(
-          'leading-slash',
-          intl.formatMessage(messages.validationUrlBaseLeadingSlash),
-          (value) => !value || value.startsWith('/')
-        )
-        .test(
-          'trailing-slash',
-          intl.formatMessage(messages.validationUrlBaseTrailingSlash),
-          (value) => !value || !value.endsWith('/')
-        ),
+      urlBase: Yup.string().matches(
+        /^(.*[^/])$/,
+        intl.formatMessage(messages.validationUrlBaseTrailingSlash)
+      ),
       email: Yup.string()
         .email(intl.formatMessage(messages.validationemailformat))
         .required(intl.formatMessage(messages.validationemailrequired)),

src/components/RequestModal/SearchByNameModal/index.tsx

@@ -88,14 +88,14 @@ const SearchByNameModal = ({
                 tvdbId === item.tvdbId ? 'ring ring-indigo-500' : ''
               } `}
             >
-              <div className="relative flex w-24 flex-none items-center space-x-4 self-stretch">
+              <div className="flex w-24 flex-none items-center space-x-4">
                 <Image
                   src={
                     item.remotePoster ??
                     '/images/overseerr_poster_not_found.png'
                   }
                   alt={item.title}
-                  className="w-100 h-auto rounded-md"
+                  className="h-100 w-auto rounded-md"
                   fill
                 />
               </div>

src/components/Selector/index.tsx

@@ -13,7 +13,6 @@ import type {
   TmdbKeywordSearchResponse,
 } from '@server/api/themoviedb/interfaces';
 import type { GenreSliderItem } from '@server/interfaces/api/discoverInterfaces';
-import type { UserResultsResponse } from '@server/interfaces/api/userInterfaces';
 import type {
   Keyword,
   ProductionCompany,
@@ -30,7 +29,6 @@ const messages = defineMessages('components.Selector', {
   searchKeywords: 'Search keywords…',
   searchGenres: 'Select genres…',
   searchStudios: 'Search studios…',
-  searchUsers: 'Select users…',
   starttyping: 'Starting typing to search.',
   nooptions: 'No results.',
   showmore: 'Show More',
@@ -439,7 +437,7 @@ export const WatchProviderSelector = ({
                   key={`prodiver-${provider.id}`}
                 >
                   <div
-                    className={`provider-container w-full cursor-pointer rounded-lg ring-1 ${
+                    className={`provider-container relative w-full cursor-pointer rounded-lg p-2 ring-1 ${
                       isActive
                         ? 'bg-gray-600 ring-indigo-500 hover:bg-gray-500'
                         : 'bg-gray-700 ring-gray-500 hover:bg-gray-600'
@@ -453,15 +451,18 @@ export const WatchProviderSelector = ({
                     role="button"
                     tabIndex={0}
                   >
-                    <div className="relative m-2 aspect-1">
-                      <CachedImage
-                        type="tmdb"
-                        src={`https://image.tmdb.org/t/p/original${provider.logoPath}`}
-                        alt=""
-                        fill
-                        className="rounded-lg object-contain"
-                      />
-                    </div>
+                    <CachedImage
+                      type="tmdb"
+                      src={`https://image.tmdb.org/t/p/original${provider.logoPath}`}
+                      alt=""
+                      style={{
+                        width: '100%',
+                        height: '100%',
+                        objectFit: 'contain',
+                      }}
+                      fill
+                      className="rounded-lg"
+                    />
                     {isActive && (
                       <div className="pointer-events-none absolute -top-1 -left-1 flex items-center justify-center text-indigo-100 opacity-90">
                         <CheckCircleIcon className="h-6 w-6" />
@@ -482,7 +483,7 @@ export const WatchProviderSelector = ({
                     key={`prodiver-${provider.id}`}
                   >
                     <div
-                      className={`provider-container w-full cursor-pointer rounded-lg ring-1 transition ${
+                      className={`provider-container relative w-full cursor-pointer rounded-lg p-2 ring-1 transition ${
                         isActive
                           ? 'bg-gray-600 ring-indigo-500 hover:bg-gray-500'
                           : 'bg-gray-700 ring-gray-500 hover:bg-gray-600'
@@ -496,15 +497,18 @@ export const WatchProviderSelector = ({
                       role="button"
                       tabIndex={0}
                     >
-                      <div className="relative m-2 aspect-1">
-                        <CachedImage
-                          type="tmdb"
-                          src={`https://image.tmdb.org/t/p/original${provider.logoPath}`}
-                          alt=""
-                          fill
-                          className="rounded-lg object-contain"
-                        />
-                      </div>
+                      <CachedImage
+                        type="tmdb"
+                        src={`https://image.tmdb.org/t/p/original${provider.logoPath}`}
+                        alt=""
+                        style={{
+                          width: '100%',
+                          height: '100%',
+                          objectFit: 'cover',
+                        }}
+                        fill
+                        className="rounded-lg"
+                      />
                       {isActive && (
                         <div className="pointer-events-none absolute -top-1 -left-1 flex items-center justify-center text-indigo-100 opacity-90">
                           <CheckCircleIcon className="h-6 w-6" />
@@ -544,77 +548,3 @@ export const WatchProviderSelector = ({
     </>
   );
 };
-
-export const UserSelector = ({
-  isMulti,
-  defaultValue,
-  onChange,
-}: BaseSelectorMultiProps | BaseSelectorSingleProps) => {
-  const intl = useIntl();
-  const [defaultDataValue, setDefaultDataValue] = useState<
-    { label: string; value: number }[] | null
-  >(null);
-
-  useEffect(() => {
-    const loadUsers = async (): Promise<void> => {
-      if (!defaultValue) {
-        return;
-      }
-
-      const users = defaultValue.split(',');
-
-      const res = await fetch(`/api/v1/user`);
-      if (!res.ok) {
-        throw new Error('Network response was not ok');
-      }
-      const response: UserResultsResponse = await res.json();
-
-      const genreData = users
-        .filter((u) => response.results.find((user) => user.id === Number(u)))
-        .map((u) => response.results.find((user) => user.id === Number(u)))
-        .map((u) => ({
-          label: u?.displayName ?? '',
-          value: u?.id ?? 0,
-        }));
-
-      setDefaultDataValue(genreData);
-    };
-
-    loadUsers();
-  }, [defaultValue]);
-
-  const loadUserOptions = async (inputValue: string) => {
-    const res = await fetch(
-      `/api/v1/user${inputValue ? `?q=${encodeURIComponent(inputValue)}` : ''}`
-    );
-    if (!res.ok) throw new Error();
-    const results: UserResultsResponse = await res.json();
-
-    return results.results
-      .map((result) => ({
-        label: result.displayName,
-        value: result.id,
-      }))
-      .filter(({ label }) =>
-        label.toLowerCase().includes(inputValue.toLowerCase())
-      );
-  };
-
-  return (
-    <AsyncSelect
-      key={`user-select-${defaultDataValue}`}
-      className="react-select-container"
-      classNamePrefix="react-select"
-      defaultValue={isMulti ? defaultDataValue : defaultDataValue?.[0]}
-      defaultOptions
-      cacheOptions
-      isMulti={isMulti}
-      loadOptions={loadUserOptions}
-      placeholder={intl.formatMessage(messages.searchUsers)}
-      onChange={(value) => {
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        onChange(value as any);
-      }}
-    />
-  );
-};

src/components/Settings/Notifications/NotificationsDiscord.tsx

@@ -19,16 +19,12 @@ const messages = defineMessages('components.Settings.Notifications', {
   webhookUrl: 'Webhook URL',
   webhookUrlTip:
     'Create a <DiscordWebhookLink>webhook integration</DiscordWebhookLink> in your server',
-  webhookRoleId: 'Notification Role ID',
-  webhookRoleIdTip:
-    'The role ID to mention in the webhook message. Leave empty to disable mentions',
   discordsettingssaved: 'Discord notification settings saved successfully!',
   discordsettingsfailed: 'Discord notification settings failed to save.',
   toastDiscordTestSending: 'Sending Discord test notification…',
   toastDiscordTestSuccess: 'Discord test notification sent!',
   toastDiscordTestFailed: 'Discord test notification failed to send.',
   validationUrl: 'You must provide a valid URL',
-  validationWebhookRoleId: 'You must provide a valid Discord Role ID',
   validationTypes: 'You must select at least one notification type',
   enableMentions: 'Enable Mentions',
 });
@@ -57,12 +53,6 @@ const NotificationsDiscord = () => {
         otherwise: Yup.string().nullable(),
       })
       .url(intl.formatMessage(messages.validationUrl)),
-    webhookRoleId: Yup.string()
-      .nullable()
-      .matches(
-        /^\d{17,19}$/,
-        intl.formatMessage(messages.validationWebhookRoleId)
-      ),
   });
 
   if (!data && !error) {
@@ -77,7 +67,6 @@ const NotificationsDiscord = () => {
         botUsername: data?.options.botUsername,
         botAvatarUrl: data?.options.botAvatarUrl,
         webhookUrl: data.options.webhookUrl,
-        webhookRoleId: data?.options.webhookRoleId,
         enableMentions: data?.options.enableMentions,
       }}
       validationSchema={NotificationsDiscordSchema}
@@ -95,7 +84,6 @@ const NotificationsDiscord = () => {
                 botUsername: values.botUsername,
                 botAvatarUrl: values.botAvatarUrl,
                 webhookUrl: values.webhookUrl,
-                webhookRoleId: values.webhookRoleId,
                 enableMentions: values.enableMentions,
               },
             }),
@@ -153,7 +141,6 @@ const NotificationsDiscord = () => {
                     botUsername: values.botUsername,
                     botAvatarUrl: values.botAvatarUrl,
                     webhookUrl: values.webhookUrl,
-                    webhookRoleId: values.webhookRoleId,
                     enableMentions: values.enableMentions,
                   },
                 }),
@@ -267,21 +254,6 @@ const NotificationsDiscord = () => {
                   )}
               </div>
             </div>
-            <div className="form-row">
-              <label htmlFor="webhookRoleId" className="text-label">
-                {intl.formatMessage(messages.webhookRoleId)}
-              </label>
-              <div className="form-input-area">
-                <div className="form-input-field">
-                  <Field id="webhookRoleId" name="webhookRoleId" type="text" />
-                </div>
-                {errors.webhookRoleId &&
-                  touched.webhookRoleId &&
-                  typeof errors.webhookRoleId === 'string' && (
-                    <div className="error">{errors.webhookRoleId}</div>
-                  )}
-              </div>
-            </div>
             <div className="form-row">
               <label htmlFor="enableMentions" className="checkbox-label">
                 {intl.formatMessage(messages.enableMentions)}

src/components/Settings/OverrideRule/OverrideRuleModal.tsx

@@ -1,391 +0,0 @@
-import Modal from '@app/components/Common/Modal';
-import LanguageSelector from '@app/components/LanguageSelector';
-import {
-  GenreSelector,
-  KeywordSelector,
-  UserSelector,
-} from '@app/components/Selector';
-import type { DVRTestResponse } from '@app/components/Settings/SettingsServices';
-import useSettings from '@app/hooks/useSettings';
-import globalMessages from '@app/i18n/globalMessages';
-import defineMessages from '@app/utils/defineMessages';
-import { Transition } from '@headlessui/react';
-import type OverrideRule from '@server/entity/OverrideRule';
-import { Field, Formik } from 'formik';
-import { useIntl } from 'react-intl';
-import Select from 'react-select';
-import { useToasts } from 'react-toast-notifications';
-
-const messages = defineMessages('components.Settings.RadarrModal', {
-  createrule: 'New Override Rule',
-  editrule: 'Edit Override Rule',
-  create: 'Create rule',
-  conditions: 'Conditions',
-  conditionsDescription:
-    'Specifies conditions before applying parameter changes. Each field must be validated for the rules to be applied (AND operation). A field is considered verified if any of its properties match (OR operation).',
-  settings: 'Settings',
-  settingsDescription:
-    'Specifies which settings will be changed when the above conditions are met.',
-  users: 'Users',
-  genres: 'Genres',
-  languages: 'Languages',
-  keywords: 'Keywords',
-  rootfolder: 'Root Folder',
-  selectRootFolder: 'Select root folder',
-  qualityprofile: 'Quality Profile',
-  selectQualityProfile: 'Select quality profile',
-  tags: 'Tags',
-  notagoptions: 'No tags.',
-  selecttags: 'Select tags',
-  ruleCreated: 'Override rule created successfully!',
-  ruleUpdated: 'Override rule updated successfully!',
-});
-
-type OptionType = {
-  value: number;
-  label: string;
-};
-
-interface OverrideRuleModalProps {
-  rule: OverrideRule | null;
-  onClose: () => void;
-  testResponse: DVRTestResponse;
-  radarrId?: number;
-  sonarrId?: number;
-}
-
-const OverrideRuleModal = ({
-  onClose,
-  rule,
-  testResponse,
-  radarrId,
-  sonarrId,
-}: OverrideRuleModalProps) => {
-  const intl = useIntl();
-  const { addToast } = useToasts();
-  const { currentSettings } = useSettings();
-
-  return (
-    <Transition
-      as="div"
-      appear
-      show
-      enter="transition-opacity ease-in-out duration-300"
-      enterFrom="opacity-0"
-      enterTo="opacity-100"
-      leave="transition-opacity ease-in-out duration-300"
-      leaveFrom="opacity-100"
-      leaveTo="opacity-0"
-    >
-      <Formik
-        initialValues={{
-          users: rule?.users,
-          genre: rule?.genre,
-          language: rule?.language,
-          keywords: rule?.keywords,
-          profileId: rule?.profileId,
-          rootFolder: rule?.rootFolder,
-          tags: rule?.tags,
-        }}
-        onSubmit={async (values) => {
-          try {
-            const submission = {
-              users: values.users || null,
-              genre: values.genre || null,
-              language: values.language || null,
-              keywords: values.keywords || null,
-              profileId: Number(values.profileId) || null,
-              rootFolder: values.rootFolder || null,
-              tags: values.tags || null,
-              radarrServiceId: radarrId,
-              sonarrServiceId: sonarrId,
-            };
-            if (!rule) {
-              const res = await fetch('/api/v1/overrideRule', {
-                method: 'POST',
-                headers: {
-                  'Content-Type': 'application/json',
-                },
-                body: JSON.stringify(submission),
-              });
-              if (!res.ok) throw new Error();
-              addToast(intl.formatMessage(messages.ruleCreated), {
-                appearance: 'success',
-                autoDismiss: true,
-              });
-            } else {
-              const res = await fetch(`/api/v1/overrideRule/${rule.id}`, {
-                method: 'PUT',
-                headers: {
-                  'Content-Type': 'application/json',
-                },
-                body: JSON.stringify(submission),
-              });
-              if (!res.ok) throw new Error();
-              addToast(intl.formatMessage(messages.ruleUpdated), {
-                appearance: 'success',
-                autoDismiss: true,
-              });
-            }
-            onClose();
-          } catch (e) {
-            // set error here
-          }
-        }}
-      >
-        {({
-          errors,
-          touched,
-          values,
-          handleSubmit,
-          setFieldValue,
-          isSubmitting,
-          isValid,
-        }) => {
-          return (
-            <Modal
-              onCancel={onClose}
-              okButtonType="primary"
-              okText={
-                isSubmitting
-                  ? intl.formatMessage(globalMessages.saving)
-                  : rule
-                  ? intl.formatMessage(globalMessages.save)
-                  : intl.formatMessage(messages.create)
-              }
-              okDisabled={
-                isSubmitting ||
-                !isValid ||
-                (!values.users &&
-                  !values.genre &&
-                  !values.language &&
-                  !values.keywords) ||
-                (!values.rootFolder && !values.profileId && !values.tags)
-              }
-              onOk={() => handleSubmit()}
-              title={
-                !rule
-                  ? intl.formatMessage(messages.createrule)
-                  : intl.formatMessage(messages.editrule)
-              }
-            >
-              <div className="mb-6">
-                <h3 className="text-lg font-bold leading-8 text-gray-100">
-                  {intl.formatMessage(messages.conditions)}
-                </h3>
-                <p className="description">
-                  {intl.formatMessage(messages.conditionsDescription)}
-                </p>
-                <div className="form-row">
-                  <label htmlFor="users" className="text-label">
-                    {intl.formatMessage(messages.users)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <UserSelector
-                        defaultValue={values.users}
-                        isMulti
-                        onChange={(users) => {
-                          setFieldValue(
-                            'users',
-                            users?.map((v) => v.value).join(',')
-                          );
-                        }}
-                      />
-                    </div>
-                    {errors.users &&
-                      touched.users &&
-                      typeof errors.users === 'string' && (
-                        <div className="error">{errors.users}</div>
-                      )}
-                  </div>
-                </div>
-                <div className="form-row">
-                  <label htmlFor="genre" className="text-label">
-                    {intl.formatMessage(messages.genres)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <GenreSelector
-                        type={radarrId ? 'movie' : 'tv'}
-                        defaultValue={values.genre}
-                        isMulti
-                        onChange={(genres) => {
-                          setFieldValue(
-                            'genre',
-                            genres?.map((v) => v.value).join(',')
-                          );
-                        }}
-                      />
-                    </div>
-                    {errors.genre &&
-                      touched.genre &&
-                      typeof errors.genre === 'string' && (
-                        <div className="error">{errors.genre}</div>
-                      )}
-                  </div>
-                </div>
-                <div className="form-row">
-                  <label htmlFor="language" className="text-label">
-                    {intl.formatMessage(messages.languages)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <LanguageSelector
-                        value={values.language}
-                        serverValue={currentSettings.originalLanguage}
-                        setFieldValue={(_key, value) => {
-                          setFieldValue('language', value);
-                        }}
-                      />
-                    </div>
-                    {errors.language &&
-                      touched.language &&
-                      typeof errors.language === 'string' && (
-                        <div className="error">{errors.language}</div>
-                      )}
-                  </div>
-                </div>
-                <div className="form-row">
-                  <label htmlFor="keywords" className="text-label">
-                    {intl.formatMessage(messages.keywords)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <KeywordSelector
-                        defaultValue={values.keywords}
-                        isMulti
-                        onChange={(value) => {
-                          setFieldValue(
-                            'keywords',
-                            value?.map((v) => v.value).join(',')
-                          );
-                        }}
-                      />
-                    </div>
-                    {errors.keywords &&
-                      touched.keywords &&
-                      typeof errors.keywords === 'string' && (
-                        <div className="error">{errors.keywords}</div>
-                      )}
-                  </div>
-                </div>
-                <h3 className="mt-4 text-lg font-bold leading-8 text-gray-100">
-                  {intl.formatMessage(messages.settings)}
-                </h3>
-                <p className="description">
-                  {intl.formatMessage(messages.settingsDescription)}
-                </p>
-                <div className="form-row">
-                  <label htmlFor="rootFolderRule" className="text-label">
-                    {intl.formatMessage(messages.rootfolder)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <Field as="select" id="rootFolderRule" name="rootFolder">
-                        <option value="">
-                          {intl.formatMessage(messages.selectRootFolder)}
-                        </option>
-                        {testResponse.rootFolders.length > 0 &&
-                          testResponse.rootFolders.map((folder) => (
-                            <option
-                              key={`loaded-profile-${folder.id}`}
-                              value={folder.path}
-                            >
-                              {folder.path}
-                            </option>
-                          ))}
-                      </Field>
-                    </div>
-                    {errors.rootFolder &&
-                      touched.rootFolder &&
-                      typeof errors.rootFolder === 'string' && (
-                        <div className="error">{errors.rootFolder}</div>
-                      )}
-                  </div>
-                </div>
-                <div className="form-row">
-                  <label htmlFor="profileIdRule" className="text-label">
-                    {intl.formatMessage(messages.qualityprofile)}
-                  </label>
-                  <div className="form-input-area">
-                    <div className="form-input-field">
-                      <Field as="select" id="profileIdRule" name="profileId">
-                        <option value="">
-                          {intl.formatMessage(messages.selectQualityProfile)}
-                        </option>
-                        {testResponse.profiles.length > 0 &&
-                          testResponse.profiles.map((profile) => (
-                            <option
-                              key={`loaded-profile-${profile.id}`}
-                              value={profile.id}
-                            >
-                              {profile.name}
-                            </option>
-                          ))}
-                      </Field>
-                    </div>
-                    {errors.profileId &&
-                      touched.profileId &&
-                      typeof errors.profileId === 'string' && (
-                        <div className="error">{errors.profileId}</div>
-                      )}
-                  </div>
-                </div>
-                <div className="form-row">
-                  <label htmlFor="tags" className="text-label">
-                    {intl.formatMessage(messages.tags)}
-                  </label>
-                  <div className="form-input-area">
-                    <Select<OptionType, true>
-                      options={testResponse.tags.map((tag) => ({
-                        label: tag.label,
-                        value: tag.id,
-                      }))}
-                      isMulti
-                      placeholder={intl.formatMessage(messages.selecttags)}
-                      className="react-select-container"
-                      classNamePrefix="react-select"
-                      value={
-                        (values?.tags
-                          ?.split(',')
-                          .map((tagId) => {
-                            const foundTag = testResponse.tags.find(
-                              (tag) => tag.id === Number(tagId)
-                            );
-
-                            if (!foundTag) {
-                              return undefined;
-                            }
-
-                            return {
-                              value: foundTag.id,
-                              label: foundTag.label,
-                            };
-                          })
-                          .filter(
-                            (option) => option !== undefined
-                          ) as OptionType[]) || []
-                      }
-                      onChange={(value) => {
-                        setFieldValue(
-                          'tags',
-                          value.map((option) => option.value).join(',')
-                        );
-                      }}
-                      noOptionsMessage={() =>
-                        intl.formatMessage(messages.notagoptions)
-                      }
-                    />
-                  </div>
-                </div>
-              </div>
-            </Modal>
-          );
-        }}
-      </Formik>
-    </Transition>
-  );
-};
-
-export default OverrideRuleModal;

src/components/Settings/OverrideRule/OverrideRuleTile.tsx

@@ -1,267 +0,0 @@
-import type { DVRTestResponse } from '@app/components/Settings/SettingsServices';
-import globalMessages from '@app/i18n/globalMessages';
-import defineMessages from '@app/utils/defineMessages';
-import { PencilIcon, TrashIcon } from '@heroicons/react/24/solid';
-import type { TmdbGenre } from '@server/api/themoviedb/interfaces';
-import type OverrideRule from '@server/entity/OverrideRule';
-import type { User } from '@server/entity/User';
-import type {
-  Language,
-  RadarrSettings,
-  SonarrSettings,
-} from '@server/lib/settings';
-import type { Keyword } from '@server/models/common';
-import { useEffect, useState } from 'react';
-import { useIntl } from 'react-intl';
-import useSWR from 'swr';
-
-const messages = defineMessages('components.Settings.OverrideRuleTile', {
-  qualityprofile: 'Quality Profile',
-  rootfolder: 'Root Folder',
-  tags: 'Tags',
-  users: 'Users',
-  genre: 'Genre',
-  language: 'Language',
-  keywords: 'Keywords',
-  conditions: 'Conditions',
-  settings: 'Settings',
-});
-
-interface OverrideRuleTileProps {
-  rules: OverrideRule[];
-  setOverrideRuleModal: ({
-    open,
-    rule,
-    testResponse,
-  }: {
-    open: boolean;
-    rule: OverrideRule | null;
-    testResponse: DVRTestResponse;
-  }) => void;
-  testResponse: DVRTestResponse;
-  radarr?: RadarrSettings | null;
-  sonarr?: SonarrSettings | null;
-  revalidate: () => void;
-}
-
-const OverrideRuleTile = ({
-  rules,
-  setOverrideRuleModal,
-  testResponse,
-  radarr,
-  sonarr,
-  revalidate,
-}: OverrideRuleTileProps) => {
-  const intl = useIntl();
-  const [users, setUsers] = useState<User[] | null>(null);
-  const [keywords, setKeywords] = useState<Keyword[] | null>(null);
-  const { data: languages } = useSWR<Language[]>('/api/v1/languages');
-  const { data: genres } = useSWR<TmdbGenre[]>('/api/v1/genres/movie');
-
-  useEffect(() => {
-    (async () => {
-      const keywords = await Promise.all(
-        rules
-          .map((rule) => rule.keywords?.split(','))
-          .flat()
-          .filter((keywordId) => keywordId)
-          .map(async (keywordId) => {
-            const res = await fetch(`/api/v1/keyword/${keywordId}`);
-            if (!res.ok) throw new Error();
-            const keyword: Keyword = await res.json();
-            return keyword;
-          })
-      );
-      setKeywords(keywords);
-      const users = await Promise.all(
-        rules
-          .map((rule) => rule.users?.split(','))
-          .flat()
-          .filter((userId) => userId)
-          .map(async (userId) => {
-            const res = await fetch(`/api/v1/user/${userId}`);
-            if (!res.ok) throw new Error();
-            const user: User = await res.json();
-            return user;
-          })
-      );
-      setUsers(users);
-    })();
-  }, [rules]);
-
-  return (
-    <>
-      {rules
-        .filter(
-          (rule) =>
-            (rule.radarrServiceId !== null &&
-              rule.radarrServiceId === radarr?.id) ||
-            (rule.sonarrServiceId !== null &&
-              rule.sonarrServiceId === sonarr?.id)
-        )
-        .map((rule) => (
-          <li className="flex h-full flex-col rounded-lg bg-gray-800 text-left shadow ring-1 ring-gray-500">
-            <div className="flex w-full flex-1 items-center justify-between space-x-6 p-6">
-              <div className="flex-1 truncate">
-                <span className="text-lg">
-                  {intl.formatMessage(messages.conditions)}
-                </span>
-                {rule.users && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.users)}
-                    </span>
-                    <div className="inline-flex gap-2">
-                      {rule.users.split(',').map((userId) => {
-                        return (
-                          <span>
-                            {
-                              users?.find((user) => user.id === Number(userId))
-                                ?.displayName
-                            }
-                          </span>
-                        );
-                      })}
-                    </div>
-                  </p>
-                )}
-                {rule.genre && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.genre)}
-                    </span>
-                    <div className="inline-flex gap-2">
-                      {rule.genre.split(',').map((genreId) => (
-                        <span>
-                          {genres?.find((g) => g.id === Number(genreId))?.name}
-                        </span>
-                      ))}
-                    </div>
-                  </p>
-                )}
-                {rule.language && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.language)}
-                    </span>
-                    <div className="inline-flex gap-2">
-                      {rule.language
-                        .split('|')
-                        .filter((languageId) => languageId !== 'server')
-                        .map((languageId) => {
-                          const language = languages?.find(
-                            (language) => language.iso_639_1 === languageId
-                          );
-                          if (!language) return null;
-                          const languageName =
-                            intl.formatDisplayName(language.iso_639_1, {
-                              type: 'language',
-                              fallback: 'none',
-                            }) ?? language.english_name;
-                          return <span>{languageName}</span>;
-                        })}
-                    </div>
-                  </p>
-                )}
-                {rule.keywords && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.keywords)}
-                    </span>
-                    <div className="inline-flex gap-2">
-                      {rule.keywords.split(',').map((keywordId) => {
-                        return (
-                          <span>
-                            {
-                              keywords?.find(
-                                (keyword) => keyword.id === Number(keywordId)
-                              )?.name
-                            }
-                          </span>
-                        );
-                      })}
-                    </div>
-                  </p>
-                )}
-                <span className="text-lg">
-                  {intl.formatMessage(messages.settings)}
-                </span>
-                {rule.profileId && (
-                  <p className="runcate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.qualityprofile)}
-                    </span>
-                    {
-                      testResponse.profiles.find(
-                        (profile) => rule.profileId === profile.id
-                      )?.name
-                    }
-                  </p>
-                )}
-                {rule.rootFolder && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.rootfolder)}
-                    </span>
-                    {rule.rootFolder}
-                  </p>
-                )}
-                {rule.tags && rule.tags.length > 0 && (
-                  <p className="truncate text-sm leading-5 text-gray-300">
-                    <span className="mr-2 font-bold">
-                      {intl.formatMessage(messages.tags)}
-                    </span>
-                    <div className="inline-flex gap-2">
-                      {rule.tags.split(',').map((tag) => (
-                        <span>
-                          {
-                            testResponse.tags?.find((t) => t.id === Number(tag))
-                              ?.label
-                          }
-                        </span>
-                      ))}
-                    </div>
-                  </p>
-                )}
-              </div>
-            </div>
-            <div className="border-t border-gray-500">
-              <div className="-mt-px flex">
-                <div className="flex w-0 flex-1 border-r border-gray-500">
-                  <button
-                    onClick={() =>
-                      setOverrideRuleModal({ open: true, rule, testResponse })
-                    }
-                    className="focus:ring-blue relative -mr-px inline-flex w-0 flex-1 items-center justify-center rounded-bl-lg border border-transparent py-4 text-sm font-medium leading-5 text-gray-200 transition duration-150 ease-in-out hover:text-white focus:z-10 focus:border-gray-500 focus:outline-none"
-                  >
-                    <PencilIcon className="mr-2 h-5 w-5" />
-                    <span>{intl.formatMessage(globalMessages.edit)}</span>
-                  </button>
-                </div>
-                <div className="-ml-px flex w-0 flex-1">
-                  <button
-                    onClick={async () => {
-                      const res = await fetch(
-                        `/api/v1/overrideRule/${rule.id}`,
-                        {
-                          method: 'DELETE',
-                        }
-                      );
-                      if (!res.ok) throw new Error();
-                      revalidate();
-                    }}
-                    className="focus:ring-blue relative inline-flex w-0 flex-1 items-center justify-center rounded-br-lg border border-transparent py-4 text-sm font-medium leading-5 text-gray-200 transition duration-150 ease-in-out hover:text-white focus:z-10 focus:border-gray-500 focus:outline-none"
-                  >
-                    <TrashIcon className="mr-2 h-5 w-5" />
-                    <span>{intl.formatMessage(globalMessages.delete)}</span>
-                  </button>
-                </div>
-              </div>
-            </div>
-          </li>
-        ))}
-    </>
-  );
-};
-
-export default OverrideRuleTile;

src/components/Settings/RadarrModal/index.tsx

@@ -1,21 +1,14 @@
-import Button from '@app/components/Common/Button';
 import Modal from '@app/components/Common/Modal';
 import SensitiveInput from '@app/components/Common/SensitiveInput';
-import OverrideRuleTile from '@app/components/Settings/OverrideRule/OverrideRuleTile';
-import type { DVRTestResponse } from '@app/components/Settings/SettingsServices';
 import globalMessages from '@app/i18n/globalMessages';
 import defineMessages from '@app/utils/defineMessages';
 import { Transition } from '@headlessui/react';
-import { PlusIcon } from '@heroicons/react/24/solid';
-import type OverrideRule from '@server/entity/OverrideRule';
-import type { OverrideRuleResultsResponse } from '@server/interfaces/api/overrideRuleInterfaces';
 import type { RadarrSettings } from '@server/lib/settings';
 import { Field, Formik } from 'formik';
 import { useCallback, useEffect, useRef, useState } from 'react';
 import { useIntl } from 'react-intl';
 import Select from 'react-select';
 import { useToasts } from 'react-toast-notifications';
-import useSWR from 'swr';
 import * as Yup from 'yup';
 
 type OptionType = {
@@ -76,46 +69,41 @@ const messages = defineMessages('components.Settings.RadarrModal', {
   announced: 'Announced',
   inCinemas: 'In Cinemas',
   released: 'Released',
-  overrideRules: 'Override Rules',
-  addrule: 'New Override Rule',
 });
 
+interface TestResponse {
+  profiles: {
+    id: number;
+    name: string;
+  }[];
+  rootFolders: {
+    id: number;
+    path: string;
+  }[];
+  tags: {
+    id: number;
+    label: string;
+  }[];
+  urlBase?: string;
+}
+
 interface RadarrModalProps {
   radarr: RadarrSettings | null;
   onClose: () => void;
   onSave: () => void;
-  overrideRuleModal: { open: boolean; rule: OverrideRule | null };
-  setOverrideRuleModal: ({
-    open,
-    rule,
-    testResponse,
-  }: {
-    open: boolean;
-    rule: OverrideRule | null;
-    testResponse: DVRTestResponse;
-  }) => void;
 }
 
-const RadarrModal = ({
-  onClose,
-  radarr,
-  onSave,
-  overrideRuleModal,
-  setOverrideRuleModal,
-}: RadarrModalProps) => {
+const RadarrModal = ({ onClose, radarr, onSave }: RadarrModalProps) => {
   const intl = useIntl();
-  const { data: rules, mutate: revalidate } =
-    useSWR<OverrideRuleResultsResponse>('/api/v1/overrideRule');
   const initialLoad = useRef(false);
   const { addToast } = useToasts();
   const [isValidated, setIsValidated] = useState(radarr ? true : false);
   const [isTesting, setIsTesting] = useState(false);
-  const [testResponse, setTestResponse] = useState<DVRTestResponse>({
+  const [testResponse, setTestResponse] = useState<TestResponse>({
     profiles: [],
     rootFolders: [],
     tags: [],
   });
-
   const RadarrSettingsSchema = Yup.object().shape({
     name: Yup.string().required(
       intl.formatMessage(messages.validationNameRequired)
@@ -142,10 +130,7 @@ const RadarrModal = ({
       intl.formatMessage(messages.validationMinimumAvailabilityRequired)
     ),
     externalUrl: Yup.string()
-      .matches(
-        /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-        intl.formatMessage(messages.validationApplicationUrl)
-      )
+      .url(intl.formatMessage(messages.validationApplicationUrl))
       .test(
         'no-trailing-slash',
         intl.formatMessage(messages.validationApplicationUrlTrailingSlash),
@@ -232,10 +217,6 @@ const RadarrModal = ({
     }
   }, [radarr, testConnection]);
 
-  useEffect(() => {
-    revalidate();
-  }, [overrideRuleModal, revalidate]);
-
   return (
     <Transition
       as="div"
@@ -379,7 +360,6 @@ const RadarrModal = ({
                       values.is4k ? messages.edit4kradarr : messages.editradarr
                     )
               }
-              backgroundClickable={!overrideRuleModal.open}
             >
               <div className="mb-6">
                 <div className="form-row">
@@ -770,38 +750,6 @@ const RadarrModal = ({
                   </div>
                 </div>
               </div>
-              <h3 className="mb-4 text-xl font-bold leading-8 text-gray-100">
-                {intl.formatMessage(messages.overrideRules)}
-              </h3>
-              <ul className="grid grid-cols-2 gap-6">
-                {rules && (
-                  <OverrideRuleTile
-                    rules={rules}
-                    setOverrideRuleModal={setOverrideRuleModal}
-                    testResponse={testResponse}
-                    radarr={radarr}
-                    revalidate={revalidate}
-                  />
-                )}
-                <li className="min-h-[8rem] rounded-lg border-2 border-dashed border-gray-400 shadow sm:min-h-[11rem]">
-                  <div className="flex h-full w-full items-center justify-center">
-                    <Button
-                      buttonType="ghost"
-                      onClick={() =>
-                        setOverrideRuleModal({
-                          open: true,
-                          rule: null,
-                          testResponse,
-                        })
-                      }
-                      disabled={!isValidated}
-                    >
-                      <PlusIcon />
-                      <span>{intl.formatMessage(messages.addrule)}</span>
-                    </Button>
-                  </div>
-                </li>
-              </ul>
             </Modal>
           );
         }}

src/components/Settings/SettingsJellyfin.tsx

@@ -139,10 +139,7 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
       ),
     jellyfinExternalUrl: Yup.string()
       .nullable()
-      .matches(
-        /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-        intl.formatMessage(messages.validationUrl)
-      )
+      .url(intl.formatMessage(messages.validationUrl))
       .test(
         'no-trailing-slash',
         intl.formatMessage(messages.validationUrlTrailingSlash),
@@ -150,10 +147,7 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
       ),
     jellyfinForgotPasswordUrl: Yup.string()
       .nullable()
-      .matches(
-        /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-        intl.formatMessage(messages.validationUrl)
-      )
+      .url(intl.formatMessage(messages.validationUrl))
       .test(
         'no-trailing-slash',
         intl.formatMessage(messages.validationUrlTrailingSlash),

src/components/Settings/SettingsMain/index.tsx

@@ -87,10 +87,7 @@ const SettingsMain = () => {
       intl.formatMessage(messages.validationApplicationTitle)
     ),
     applicationUrl: Yup.string()
-      .matches(
-        /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-        intl.formatMessage(messages.validationApplicationUrl)
-      )
+      .url(intl.formatMessage(messages.validationApplicationUrl))
       .test(
         'no-trailing-slash',
         intl.formatMessage(messages.validationApplicationUrlTrailingSlash),

src/components/Settings/SettingsPlex.tsx

@@ -190,10 +190,7 @@ const SettingsPlex = ({ onComplete }: SettingsPlexProps) => {
         otherwise: Yup.string().nullable(),
       }),
       tautulliExternalUrl: Yup.string()
-        .matches(
-          /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-          intl.formatMessage(messages.validationUrl)
-        )
+        .url(intl.formatMessage(messages.validationUrl))
         .test(
           'no-trailing-slash',
           intl.formatMessage(messages.validationUrlTrailingSlash),

src/components/Settings/SettingsServices.tsx

@@ -6,14 +6,12 @@ import Button from '@app/components/Common/Button';
 import LoadingSpinner from '@app/components/Common/LoadingSpinner';
 import Modal from '@app/components/Common/Modal';
 import PageTitle from '@app/components/Common/PageTitle';
-import OverrideRuleModal from '@app/components/Settings/OverrideRule/OverrideRuleModal';
 import RadarrModal from '@app/components/Settings/RadarrModal';
 import SonarrModal from '@app/components/Settings/SonarrModal';
 import globalMessages from '@app/i18n/globalMessages';
 import defineMessages from '@app/utils/defineMessages';
 import { Transition } from '@headlessui/react';
 import { PencilIcon, PlusIcon, TrashIcon } from '@heroicons/react/24/solid';
-import type OverrideRule from '@server/entity/OverrideRule';
 import type { RadarrSettings, SonarrSettings } from '@server/lib/settings';
 import { Fragment, useState } from 'react';
 import { useIntl } from 'react-intl';
@@ -59,22 +57,6 @@ interface ServerInstanceProps {
   onDelete: () => void;
 }
 
-export interface DVRTestResponse {
-  profiles: {
-    id: number;
-    name: string;
-  }[];
-  rootFolders: {
-    id: number;
-    path: string;
-  }[];
-  tags: {
-    id: number;
-    label: string;
-  }[];
-  urlBase?: string;
-}
-
 const ServerInstance = ({
   name,
   hostname,
@@ -211,15 +193,6 @@ const SettingsServices = () => {
     type: 'radarr',
     serverId: null,
   });
-  const [overrideRuleModal, setOverrideRuleModal] = useState<{
-    open: boolean;
-    rule: OverrideRule | null;
-    testResponse: DVRTestResponse | null;
-  }>({
-    open: false,
-    rule: null,
-    testResponse: null,
-  });
 
   const deleteServer = async () => {
     const res = await fetch(
@@ -254,51 +227,26 @@ const SettingsServices = () => {
           })}
         </p>
       </div>
-      {overrideRuleModal.open && overrideRuleModal.testResponse && (
-        <OverrideRuleModal
-          rule={overrideRuleModal.rule}
-          onClose={() =>
-            setOverrideRuleModal({
-              open: false,
-              rule: null,
-              testResponse: null,
-            })
-          }
-          testResponse={overrideRuleModal.testResponse}
-          radarrId={editRadarrModal.radarr?.id}
-          sonarrId={editSonarrModal.sonarr?.id}
-        />
-      )}
       {editRadarrModal.open && (
         <RadarrModal
           radarr={editRadarrModal.radarr}
-          onClose={() => {
-            if (!overrideRuleModal.open)
-              setEditRadarrModal({ open: false, radarr: null });
-          }}
+          onClose={() => setEditRadarrModal({ open: false, radarr: null })}
           onSave={() => {
             revalidateRadarr();
             mutate('/api/v1/settings/public');
             setEditRadarrModal({ open: false, radarr: null });
           }}
-          overrideRuleModal={overrideRuleModal}
-          setOverrideRuleModal={setOverrideRuleModal}
         />
       )}
       {editSonarrModal.open && (
         <SonarrModal
           sonarr={editSonarrModal.sonarr}
-          onClose={() => {
-            if (!overrideRuleModal.open)
-              setEditSonarrModal({ open: false, sonarr: null });
-          }}
+          onClose={() => setEditSonarrModal({ open: false, sonarr: null })}
           onSave={() => {
             revalidateSonarr();
             mutate('/api/v1/settings/public');
             setEditSonarrModal({ open: false, sonarr: null });
           }}
-          overrideRuleModal={overrideRuleModal}
-          setOverrideRuleModal={setOverrideRuleModal}
         />
       )}
       <Transition

src/components/Settings/SonarrModal/index.tsx

@@ -1,14 +1,8 @@
-import Button from '@app/components/Common/Button';
 import Modal from '@app/components/Common/Modal';
 import SensitiveInput from '@app/components/Common/SensitiveInput';
-import OverrideRuleTile from '@app/components/Settings/OverrideRule/OverrideRuleTile';
-import type { DVRTestResponse } from '@app/components/Settings/SettingsServices';
 import globalMessages from '@app/i18n/globalMessages';
 import defineMessages from '@app/utils/defineMessages';
 import { Transition } from '@headlessui/react';
-import { PlusIcon } from '@heroicons/react/24/solid';
-import type OverrideRule from '@server/entity/OverrideRule';
-import type { OverrideRuleResultsResponse } from '@server/interfaces/api/overrideRuleInterfaces';
 import type { SonarrSettings } from '@server/lib/settings';
 import { Field, Formik } from 'formik';
 import { useCallback, useEffect, useRef, useState } from 'react';
@@ -16,7 +10,6 @@ import { useIntl } from 'react-intl';
 import type { OnChangeValue } from 'react-select';
 import Select from 'react-select';
 import { useToasts } from 'react-toast-notifications';
-import useSWR from 'swr';
 import * as Yup from 'yup';
 
 type OptionType = {
@@ -82,56 +75,48 @@ const messages = defineMessages('components.Settings.SonarrModal', {
   animeTags: 'Anime Tags',
   notagoptions: 'No tags.',
   selecttags: 'Select tags',
-  overrideRules: 'Override Rules',
-  addrule: 'New Override Rule',
 });
 
-interface SonarrTestResponse extends DVRTestResponse {
+interface TestResponse {
+  profiles: {
+    id: number;
+    name: string;
+  }[];
+  rootFolders: {
+    id: number;
+    path: string;
+  }[];
   languageProfiles:
     | {
         id: number;
         name: string;
       }[]
     | null;
+  tags: {
+    id: number;
+    label: string;
+  }[];
+  urlBase?: string;
 }
 
 interface SonarrModalProps {
   sonarr: SonarrSettings | null;
   onClose: () => void;
   onSave: () => void;
-  overrideRuleModal: { open: boolean; rule: OverrideRule | null };
-  setOverrideRuleModal: ({
-    open,
-    rule,
-    testResponse,
-  }: {
-    open: boolean;
-    rule: OverrideRule | null;
-    testResponse: DVRTestResponse;
-  }) => void;
 }
 
-const SonarrModal = ({
-  onClose,
-  sonarr,
-  onSave,
-  overrideRuleModal,
-  setOverrideRuleModal,
-}: SonarrModalProps) => {
+const SonarrModal = ({ onClose, sonarr, onSave }: SonarrModalProps) => {
   const intl = useIntl();
-  const { data: rules, mutate: revalidate } =
-    useSWR<OverrideRuleResultsResponse>('/api/v1/overrideRule');
   const initialLoad = useRef(false);
   const { addToast } = useToasts();
   const [isValidated, setIsValidated] = useState(sonarr ? true : false);
   const [isTesting, setIsTesting] = useState(false);
-  const [testResponse, setTestResponse] = useState<SonarrTestResponse>({
+  const [testResponse, setTestResponse] = useState<TestResponse>({
     profiles: [],
     rootFolders: [],
     languageProfiles: null,
     tags: [],
   });
-
   const SonarrSettingsSchema = Yup.object().shape({
     name: Yup.string().required(
       intl.formatMessage(messages.validationNameRequired)
@@ -160,10 +145,7 @@ const SonarrModal = ({
         )
       : Yup.number(),
     externalUrl: Yup.string()
-      .matches(
-        /^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}(\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&/=]*))?$/i,
-        intl.formatMessage(messages.validationApplicationUrl)
-      )
+      .url(intl.formatMessage(messages.validationApplicationUrl))
       .test(
         'no-trailing-slash',
         intl.formatMessage(messages.validationApplicationUrlTrailingSlash),
@@ -212,7 +194,7 @@ const SonarrModal = ({
           }),
         });
         if (!res.ok) throw new Error();
-        const data: SonarrTestResponse = await res.json();
+        const data: TestResponse = await res.json();
 
         setIsValidated(true);
         setTestResponse(data);
@@ -250,10 +232,6 @@ const SonarrModal = ({
     }
   }, [sonarr, testConnection]);
 
-  useEffect(() => {
-    revalidate();
-  }, [overrideRuleModal, revalidate]);
-
   return (
     <Transition
       as="div"
@@ -421,7 +399,6 @@ const SonarrModal = ({
                       values.is4k ? messages.edit4ksonarr : messages.editsonarr
                     )
               }
-              backgroundClickable={!overrideRuleModal.open}
             >
               <div className="mb-6">
                 <div className="form-row">
@@ -1076,38 +1053,6 @@ const SonarrModal = ({
                   </div>
                 </div>
               </div>
-              <h3 className="mb-4 text-xl font-bold leading-8 text-gray-100">
-                {intl.formatMessage(messages.overrideRules)}
-              </h3>
-              <ul className="grid grid-cols-2 gap-6">
-                {rules && (
-                  <OverrideRuleTile
-                    rules={rules}
-                    setOverrideRuleModal={setOverrideRuleModal}
-                    testResponse={testResponse}
-                    sonarr={sonarr}
-                    revalidate={revalidate}
-                  />
-                )}
-                <li className="min-h-[8rem] rounded-lg border-2 border-dashed border-gray-400 shadow sm:min-h-[11rem]">
-                  <div className="flex h-full w-full items-center justify-center">
-                    <Button
-                      buttonType="ghost"
-                      onClick={() =>
-                        setOverrideRuleModal({
-                          open: true,
-                          rule: null,
-                          testResponse,
-                        })
-                      }
-                      disabled={!isValidated}
-                    >
-                      <PlusIcon />
-                      <span>{intl.formatMessage(messages.addrule)}</span>
-                    </Button>
-                  </div>
-                </li>
-              </ul>
             </Modal>
           );
         }}

src/components/UserProfile/UserSettings/UserGeneralSettings/index.tsx

@@ -44,8 +44,6 @@ const messages = defineMessages(
     toastSettingsSuccess: 'Settings saved successfully!',
     toastSettingsFailure: 'Something went wrong while saving settings.',
     toastSettingsFailureEmail: 'This email is already taken!',
-    toastSettingsFailureEmailEmpty:
-      'Another user already has this username. You must set an email',
     region: 'Discover Region',
     regionTip: 'Filter content by regional availability',
     originallanguage: 'Discover Language',
@@ -140,7 +138,7 @@ const UserGeneralSettings = () => {
       </div>
       <Formik
         initialValues={{
-          displayName: data?.username !== user?.email ? data?.username : '',
+          displayName: data?.username ?? '',
           email: data?.email?.includes('@') ? data.email : '',
           discordId: data?.discordId ?? '',
           locale: data?.locale,
@@ -205,23 +203,10 @@ const UserGeneralSettings = () => {
               /* empty */
             }
             if (errorData?.message === ApiErrorCode.InvalidEmail) {
-              if (values.email) {
-                addToast(
-                  intl.formatMessage(messages.toastSettingsFailureEmail),
-                  {
-                    autoDismiss: true,
-                    appearance: 'error',
-                  }
-                );
-              } else {
-                addToast(
-                  intl.formatMessage(messages.toastSettingsFailureEmailEmpty),
-                  {
-                    autoDismiss: true,
-                    appearance: 'error',
-                  }
-                );
-              }
+              addToast(intl.formatMessage(messages.toastSettingsFailureEmail), {
+                autoDismiss: true,
+                appearance: 'error',
+              });
             } else {
               addToast(intl.formatMessage(messages.toastSettingsFailure), {
                 autoDismiss: true,
@@ -299,9 +284,9 @@ const UserGeneralSettings = () => {
                       name="displayName"
                       type="text"
                       placeholder={
+                        user?.username ||
                         user?.jellyfinUsername ||
-                        user?.plexUsername ||
-                        user?.email
+                        user?.plexUsername
                       }
                     />
                   </div>

src/i18n/extractMessages.ts

@@ -25,14 +25,15 @@ async function extractMessages(
     try {
       const formattedMessages = messages
         .trim()
-        .replace(/^\s*(['"])?([a-zA-Z0-9_-]+)(['"])?:[\s\n]*/gm, '"$2":')
-        .replace(/^"[a-zA-Z0-9_-]+":'.*',?$/gm, (match) => {
-          const parts = /^("[a-zA-Z0-9_-]+":)'(.*)',?$/.exec(match);
-          if (!parts) return match;
-          return `${parts[1]}"${parts[2]
-            .replace(/\\/g, '\\\\')
-            .replace(/"/g, '\\"')}",`;
-        })
+        .replace(/^\s*(['"])?([a-zA-Z0-9_-]+)(['"])?:/gm, '"$2":')
+        .replace(
+          /'.*'/g,
+          (match) =>
+            `"${match
+              .match(/'(.*)'/)?.[1]
+              .replace(/\\/g, '\\\\')
+              .replace(/"/g, '\\"')}"`
+        )
         .replace(/,$/, '');
       const messagesJson = JSON.parse(`{${formattedMessages}}`);
       return { namespace: namespace.trim(), messages: messagesJson };

src/i18n/locale/en.json

@@ -100,7 +100,6 @@
   "components.Discover.StudioSlider.studios": "Studios",
   "components.Discover.TvGenreList.seriesgenres": "Series Genres",
   "components.Discover.TvGenreSlider.tvgenres": "Series Genres",
-  "components.DiscoverTvUpcoming.upcomingtv": "Upcoming Series",
   "components.Discover.createnewslider": "Create New Slider",
   "components.Discover.customizediscover": "Customize Discover",
   "components.Discover.discover": "Discover",
@@ -299,6 +298,7 @@
   "components.ManageSlideOver.plays": "<strong>{playCount, number}</strong> {playCount, plural, one {play} other {plays}}",
   "components.ManageSlideOver.removearr": "Remove from {arr}",
   "components.ManageSlideOver.removearr4k": "Remove from 4K {arr}",
+  "components.RequestList.RequestItem.removearr": "Remove from {arr}",
   "components.ManageSlideOver.tvshow": "series",
   "components.MediaSlider.ShowMoreCard.seemore": "See More",
   "components.MovieDetails.MovieCast.fullcast": "Full Cast",
@@ -494,7 +494,6 @@
   "components.RequestList.RequestItem.modified": "Modified",
   "components.RequestList.RequestItem.modifieduserdate": "{date} by {user}",
   "components.RequestList.RequestItem.profileName": "Profile",
-  "components.RequestList.RequestItem.removearr": "Remove from {arr}",
   "components.RequestList.RequestItem.requested": "Requested",
   "components.RequestList.RequestItem.requesteddate": "Requested",
   "components.RequestList.RequestItem.seasons": "{seasonCount, plural, one {Season} other {Seasons}}",
@@ -590,7 +589,6 @@
   "components.Selector.searchKeywords": "Search keywords…",
   "components.Selector.searchStatus": "Select status...",
   "components.Selector.searchStudios": "Search studios…",
-  "components.Selector.searchUsers": "Select users…",
   "components.Selector.showless": "Show Less",
   "components.Selector.showmore": "Show More",
   "components.Selector.starttyping": "Starting typing to search.",
@@ -729,63 +727,37 @@
   "components.Settings.Notifications.validationSmtpPortRequired": "You must provide a valid port number",
   "components.Settings.Notifications.validationTypes": "You must select at least one notification type",
   "components.Settings.Notifications.validationUrl": "You must provide a valid URL",
-  "components.Settings.Notifications.validationWebhookRoleId": "You must provide a valid Discord Role ID",
-  "components.Settings.Notifications.webhookRoleId": "Notification Role ID",
-  "components.Settings.Notifications.webhookRoleIdTip": "The role ID to mention in the webhook message. Leave empty to disable mentions",
   "components.Settings.Notifications.webhookUrl": "Webhook URL",
   "components.Settings.Notifications.webhookUrlTip": "Create a <DiscordWebhookLink>webhook integration</DiscordWebhookLink> in your server",
-  "components.Settings.OverrideRuleTile.conditions": "Conditions",
-  "components.Settings.OverrideRuleTile.genre": "Genre",
-  "components.Settings.OverrideRuleTile.keywords": "Keywords",
-  "components.Settings.OverrideRuleTile.language": "Language",
-  "components.Settings.OverrideRuleTile.qualityprofile": "Quality Profile",
-  "components.Settings.OverrideRuleTile.rootfolder": "Root Folder",
-  "components.Settings.OverrideRuleTile.settings": "Settings",
-  "components.Settings.OverrideRuleTile.tags": "Tags",
-  "components.Settings.OverrideRuleTile.users": "Users",
   "components.Settings.RadarrModal.add": "Add Server",
-  "components.Settings.RadarrModal.addrule": "New Override Rule",
   "components.Settings.RadarrModal.announced": "Announced",
   "components.Settings.RadarrModal.apiKey": "API Key",
   "components.Settings.RadarrModal.baseUrl": "URL Base",
-  "components.Settings.RadarrModal.conditions": "Conditions",
-  "components.Settings.RadarrModal.conditionsDescription": "Specifies conditions before applying parameter changes. Each field must be validated for the rules to be applied (AND operation). A field is considered verified if any of its properties match (OR operation).",
-  "components.Settings.RadarrModal.create": "Create rule",
   "components.Settings.RadarrModal.create4kradarr": "Add New 4K Radarr Server",
   "components.Settings.RadarrModal.createradarr": "Add New Radarr Server",
-  "components.Settings.RadarrModal.createrule": "New Override Rule",
   "components.Settings.RadarrModal.default4kserver": "Default 4K Server",
   "components.Settings.RadarrModal.defaultserver": "Default Server",
   "components.Settings.RadarrModal.edit4kradarr": "Edit 4K Radarr Server",
   "components.Settings.RadarrModal.editradarr": "Edit Radarr Server",
-  "components.Settings.RadarrModal.editrule": "Edit Override Rule",
   "components.Settings.RadarrModal.enableSearch": "Enable Automatic Search",
   "components.Settings.RadarrModal.externalUrl": "External URL",
-  "components.Settings.RadarrModal.genres": "Genres",
   "components.Settings.RadarrModal.hostname": "Hostname or IP Address",
   "components.Settings.RadarrModal.inCinemas": "In Cinemas",
-  "components.Settings.RadarrModal.keywords": "Keywords",
-  "components.Settings.RadarrModal.languages": "Languages",
   "components.Settings.RadarrModal.loadingTags": "Loading tags…",
   "components.Settings.RadarrModal.loadingprofiles": "Loading quality profiles…",
   "components.Settings.RadarrModal.loadingrootfolders": "Loading root folders…",
   "components.Settings.RadarrModal.minimumAvailability": "Minimum Availability",
   "components.Settings.RadarrModal.notagoptions": "No tags.",
-  "components.Settings.RadarrModal.overrideRules": "Override Rules",
   "components.Settings.RadarrModal.port": "Port",
   "components.Settings.RadarrModal.qualityprofile": "Quality Profile",
   "components.Settings.RadarrModal.released": "Released",
   "components.Settings.RadarrModal.rootfolder": "Root Folder",
-  "components.Settings.RadarrModal.ruleCreated": "Override rule created successfully!",
-  "components.Settings.RadarrModal.ruleUpdated": "Override rule updated successfully!",
   "components.Settings.RadarrModal.selectMinimumAvailability": "Select minimum availability",
   "components.Settings.RadarrModal.selectQualityProfile": "Select quality profile",
   "components.Settings.RadarrModal.selectRootFolder": "Select root folder",
   "components.Settings.RadarrModal.selecttags": "Select tags",
   "components.Settings.RadarrModal.server4k": "4K Server",
   "components.Settings.RadarrModal.servername": "Server Name",
-  "components.Settings.RadarrModal.settings": "Settings",
-  "components.Settings.RadarrModal.settingsDescription": "Specifies which settings will be changed when the above conditions are met.",
   "components.Settings.RadarrModal.ssl": "Use SSL",
   "components.Settings.RadarrModal.syncEnabled": "Enable Scan",
   "components.Settings.RadarrModal.tagRequests": "Tag Requests",
@@ -796,7 +768,6 @@
   "components.Settings.RadarrModal.testFirstTags": "Test connection to load tags",
   "components.Settings.RadarrModal.toastRadarrTestFailure": "Failed to connect to Radarr.",
   "components.Settings.RadarrModal.toastRadarrTestSuccess": "Radarr connection established successfully!",
-  "components.Settings.RadarrModal.users": "Users",
   "components.Settings.RadarrModal.validationApiKeyRequired": "You must provide an API key",
   "components.Settings.RadarrModal.validationApplicationUrl": "You must provide a valid URL",
   "components.Settings.RadarrModal.validationApplicationUrlTrailingSlash": "URL must not end in a trailing slash",
@@ -914,15 +885,6 @@
   "components.Settings.SettingsMain.originallanguage": "Discover Language",
   "components.Settings.SettingsMain.originallanguageTip": "Filter content by original language",
   "components.Settings.SettingsMain.partialRequestsEnabled": "Allow Partial Series Requests",
-  "components.Settings.SettingsMain.proxyBypassFilter": "Proxy Ignored Addresses",
-  "components.Settings.SettingsMain.proxyBypassFilterTip": "Use ',' as a separator, and '*.' as a wildcard for subdomains",
-  "components.Settings.SettingsMain.proxyBypassLocalAddresses": "Bypass Proxy for Local Addresses",
-  "components.Settings.SettingsMain.proxyEnabled": "HTTP(S) Proxy",
-  "components.Settings.SettingsMain.proxyHostname": "Proxy Hostname",
-  "components.Settings.SettingsMain.proxyPassword": "Proxy Password",
-  "components.Settings.SettingsMain.proxyPort": "Proxy Port",
-  "components.Settings.SettingsMain.proxySsl": "Use SSL For Proxy",
-  "components.Settings.SettingsMain.proxyUser": "Proxy Username",
   "components.Settings.SettingsMain.region": "Discover Region",
   "components.Settings.SettingsMain.regionTip": "Filter content by regional availability",
   "components.Settings.SettingsMain.toastApiKeyFailure": "Something went wrong while generating a new API key.",
@@ -934,7 +896,6 @@
   "components.Settings.SettingsMain.validationApplicationTitle": "You must provide an application title",
   "components.Settings.SettingsMain.validationApplicationUrl": "You must provide a valid URL",
   "components.Settings.SettingsMain.validationApplicationUrlTrailingSlash": "URL must not end in a trailing slash",
-  "components.Settings.SettingsMain.validationProxyPort": "You must provide a valid port",
   "components.Settings.SettingsUsers.defaultPermissions": "Default Permissions",
   "components.Settings.SettingsUsers.defaultPermissionsTip": "Initial permissions assigned to new users",
   "components.Settings.SettingsUsers.localLogin": "Enable Local Sign-In",
@@ -949,7 +910,6 @@
   "components.Settings.SettingsUsers.userSettingsDescription": "Configure global and default user settings.",
   "components.Settings.SettingsUsers.users": "Users",
   "components.Settings.SonarrModal.add": "Add Server",
-  "components.Settings.SonarrModal.addrule": "New Override Rule",
   "components.Settings.SonarrModal.animeSeriesType": "Anime Series Type",
   "components.Settings.SonarrModal.animeTags": "Anime Tags",
   "components.Settings.SonarrModal.animelanguageprofile": "Anime Language Profile",
@@ -972,7 +932,6 @@
   "components.Settings.SonarrModal.loadingprofiles": "Loading quality profiles…",
   "components.Settings.SonarrModal.loadingrootfolders": "Loading root folders…",
   "components.Settings.SonarrModal.notagoptions": "No tags.",
-  "components.Settings.SonarrModal.overrideRules": "Override Rules",
   "components.Settings.SonarrModal.port": "Port",
   "components.Settings.SonarrModal.qualityprofile": "Quality Profile",
   "components.Settings.SonarrModal.rootfolder": "Root Folder",
@@ -1125,7 +1084,7 @@
   "components.Setup.finishing": "Finishing…",
   "components.Setup.servertype": "Choose Server Type",
   "components.Setup.setup": "Setup",
-  "components.Setup.signin": "Sign In",
+  "components.Setup.signin": "Sign in to your account",
   "components.Setup.signinMessage": "Get started by signing in",
   "components.Setup.signinWithEmby": "Enter your Emby details",
   "components.Setup.signinWithJellyfin": "Enter your Jellyfin details",
@@ -1276,7 +1235,6 @@
   "components.UserProfile.UserSettings.UserGeneralSettings.seriesrequestlimit": "Series Request Limit",
   "components.UserProfile.UserSettings.UserGeneralSettings.toastSettingsFailure": "Something went wrong while saving settings.",
   "components.UserProfile.UserSettings.UserGeneralSettings.toastSettingsFailureEmail": "This email is already taken!",
-  "components.UserProfile.UserSettings.UserGeneralSettings.toastSettingsFailureEmailEmpty": "Another user already has this username. You must set an email",
   "components.UserProfile.UserSettings.UserGeneralSettings.toastSettingsSuccess": "Settings saved successfully!",
   "components.UserProfile.UserSettings.UserGeneralSettings.user": "User",
   "components.UserProfile.UserSettings.UserGeneralSettings.validationDiscordId": "You must provide a valid Discord user ID",

src/utils/defineMessages.ts

@@ -1,26 +1,18 @@
 import { defineMessages as intlDefineMessages } from 'react-intl';
 
-type Messages<T extends Record<string, string>> = {
-  [K in keyof T]: {
-    id: string;
-    defaultMessage: T[K];
-  };
-};
-
-export default function defineMessages<T extends Record<string, string>>(
+export default function defineMessages(
   prefix: string,
-  messages: T
-): Messages<T> {
-  const keys: (keyof T)[] = Object.keys(messages);
-  const modifiedMessagesEntries = keys.map((key) => [
-    key,
-    {
-      id: `${prefix}.${key as string}`,
+  messages: Record<string, string>
+) {
+  const modifiedMessages: Record<
+    string,
+    { id: string; defaultMessage: string }
+  > = {};
+  for (const key of Object.keys(messages)) {
+    modifiedMessages[key] = {
+      id: prefix + '.' + key,
       defaultMessage: messages[key],
-    },
-  ]);
-  const modifiedMessages: Messages<T> = Object.fromEntries(
-    modifiedMessagesEntries
-  );
+    };
+  }
   return intlDefineMessages(modifiedMessages);
 }