refactor: clean up commented out code

This commit is contained in:
fallenbagel
2024-05-26 19:38:39 +05:00
parent 822a0768cf
commit 57336d8a75
5 changed files with 1 additions and 65 deletions

View File

@@ -213,19 +213,12 @@ class Media {
const pageName =
process.env.JELLYFIN_TYPE === 'emby' ? 'item' : 'details';
const { serverId, externalHostname } = getSettings().jellyfin;
// let jellyfinHost =
// externalHostname && externalHostname.length > 0
// ? externalHostname
// : hostname;
const jellyfinHost =
externalHostname && externalHostname.length > 0
? externalHostname
: getHostname();
// jellyfinHost = jellyfinHost.endsWith('/')
// ? jellyfinHost.slice(0, -1)
// : jellyfinHost;
if (this.jellyfinMediaId) {
this.mediaUrl = `${jellyfinHost}/web/index.html#!/${pageName}?id=${this.jellyfinMediaId}&context=home&serverId=${serverId}`;
}

View File

@@ -85,7 +85,6 @@ class AvailabilitySync {
) {
if (admin) {
this.jellyfinClient = new JellyfinAPI(
// settings.jellyfin. ?? '',
getHostname(),
admin.jellyfinAuthToken,
admin.jellyfinDeviceId

View File

@@ -133,7 +133,6 @@ interface FullPublicSettings extends PublicSettings {
region: string;
originalLanguage: string;
mediaServerType: number;
jellyfinHost?: string;
jellyfinExternalHost?: string;
jellyfinForgotPasswordUrl?: string;
jellyfinServerName?: string;
@@ -552,8 +551,6 @@ class Settings {
region: this.data.main.region,
originalLanguage: this.data.main.originalLanguage,
mediaServerType: this.main.mediaServerType,
// jellyfinHost: this.jellyfin.hostname,
// jellyfinExternalHost: this.jellyfin.externalHostname,
partialRequestsEnabled: this.data.main.partialRequestsEnabled,
cacheImages: this.data.main.cacheImages,
vapidPublic: this.vapidPublic,

View File

@@ -59,17 +59,6 @@ const JellyfinLogin: React.FC<JellyfinLoginProps> = ({
if (initial) {
const LoginSchema = Yup.object().shape({
// host: Yup.string()
// .matches(
// /^(?:(?:(?:https?):)?\/\/)(?:\S+(?::\S*)?@)?(?:(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)(?:\.(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)*\.?)(?::\d{2,5})?(?:[/?#]\S*)?$/,
// intl.formatMessage(messages.validationhostformat)
// )
// .required(
// intl.formatMessage(messages.validationhostrequired, {
// mediaServerName:
// publicRuntimeConfig.JELLYFIN_TYPE == 'emby' ? 'Emby' : 'Jellyfin',
// })
// ),
hostname: Yup.string().required(
intl.formatMessage(messages.validationhostrequired, {
mediaServerName:
@@ -164,25 +153,6 @@ const JellyfinLogin: React.FC<JellyfinLoginProps> = ({
}) => (
<Form>
<div className="sm:border-t sm:border-gray-800">
{/* <label htmlFor="host" className="text-label">
{intl.formatMessage(messages.host, mediaServerFormatValues)}
</label> */}
{/* <div className="mt-1 mb-2 sm:col-span-2 sm:mt-0">
<div className="flex rounded-md shadow-sm">
<Field
id="host"
name="host"
type="text"
placeholder={intl.formatMessage(
messages.host,
mediaServerFormatValues
)}
/>
</div>
{errors.host && touched.host && (
<div className="error">{errors.host}</div>
)}
</div> */}
<div className="flex flex-col sm:flex-row sm:gap-4">
<div className="w-full">
<label htmlFor="hostname" className="text-label">

View File

@@ -33,7 +33,6 @@ const messages = defineMessages({
jellyfinSettingsDescription:
'Optionally configure the internal and external endpoints for your {mediaServerName} server. In most cases, the external URL is different to the internal URL. A custom password reset URL can also be set for {mediaServerName} login, in case you would like to redirect to a different password reset page.',
externalUrl: 'External URL',
// internalUrl: 'Internal URL',
hostname: 'Hostname or IP Address',
port: 'Port',
enablessl: 'Use SSL',
@@ -438,7 +437,6 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
</div>
<Formik
initialValues={{
// jellyfinInternalUrl: data?.hostname || '',
hostname: data?.ip,
port: data?.port ?? 8096,
useSsl: data?.useSsl,
@@ -514,27 +512,6 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
}) => {
return (
<form className="section" onSubmit={handleSubmit}>
{/* <div className="form-row">
<label htmlFor="jellyfinInternalUrl" className="text-label">
{intl.formatMessage(messages.internalUrl)}
</label>
<div className="form-input-area">
<div className="form-input-field">
<Field
type="text"
inputMode="url"
id="jellyfinInternalUrl"
name="jellyfinInternalUrl"
/>
</div>
{errors.jellyfinInternalUrl &&
touched.jellyfinInternalUrl && (
<div className="error">
{errors.jellyfinInternalUrl}
</div>
)}
</div>
</div> */}
<div className="form-row">
<label htmlFor="hostname" className="text-label">
{intl.formatMessage(messages.hostname)}