mirrors/jellyseerr
1
0
Fork 0
mirror of https://github.com/fallenbagel/jellyseerr.git synced 2025-12-23 18:29:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(webpush): improve push notification error handling

Browse Source 
Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>
This commit is contained in:
0xsysr3ll
2025-11-15 21:48:30 +01:00
parent 3f899f5e76
commit 381d82488e
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
server/lib/notifications/agents/webpush.ts
View File

@@ -188,19 +188,30 @@ class WebPushAgent
notificationPayload
);
} catch (e) {
const statusCode = (e as any).statusCode || (e as any).status;
const isPermanentFailure = statusCode === 410 || statusCode === 404;
logger.error(
'Error sending web push notification; removing subscription',
isPermanentFailure
? 'Error sending web push notification; removing invalid subscription'
: 'Error sending web push notification (transient error, keeping subscription)',
{
label: 'Notifications',
recipient: pushSub.user.displayName,
type: Notification[type],
subject: payload.subject,
errorMessage: e.message,
errorMessage: (e as Error).message || String(e),
statusCode: statusCode || 'unknown',
errorBody: (e as any).body || (e as any).response?.body,
endpoint: pushSub.endpoint.substring(0, 50) + '...',
}
);
// Failed to send notification so we need to remove the subscription
userPushSubRepository.remove(pushSub);
// Only remove subscription for permanent failures
// Transient errors should not remove the subscription
if (isPermanentFailure) {
await userPushSubRepository.remove(pushSub);
}
}
};