mirrors/archon
1
0
Fork 0
mirror of https://github.com/coleam00/Archon.git synced 2025-12-24 02:39:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Improve optimistic updates with proper TypeScript types

Browse Source 
- Replace any types with proper KnowledgeItemsResponse typing
- Add support for title field updates in optimistic cache updates
- Ensure metadata synchronization with top-level fields (tags, knowledge_type)
- Add type guards for all update fields (string, array validation)
- Initialize metadata if missing to prevent undefined errors
- Maintain immutability with proper object spreading
- Protect tag editing state from external prop updates during editing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
leex279
2025-09-14 16:06:04 +02:00
committed by Wirasm
parent 09bb36f9b6
commit 5a5f763795
1 changed files with 49 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
archon-ui-main/src/features/knowledge/hooks/useKnowledgeQueries.ts
View File

@@ -558,45 +558,73 @@ export function useUpdateKnowledgeItem() {
if (previousItem) {
const updatedItem = { ...previousItem };
// Handle metadata updates properly
if ('tags' in updates) {
const newTags = updates.tags as string[];
// Update both top-level tags and metadata.tags for consistency
(updatedItem as any).tags = newTags;
updatedItem.metadata = { ...updatedItem.metadata, tags: newTags };
// Initialize metadata if missing
const currentMetadata = updatedItem.metadata || {};
// Handle title updates
if ('title' in updates && typeof updates.title === 'string') {
updatedItem.title = updates.title;
}
if ('knowledge_type' in updates) {
const newType = updates.knowledge_type as string;
// Update both top-level knowledge_type and metadata.knowledge_type for consistency
updatedItem.knowledge_type = newType as "technical" | "business";
updatedItem.metadata = { ...updatedItem.metadata, knowledge_type: newType };
// Handle tags updates
if ('tags' in updates && Array.isArray(updates.tags)) {
const newTags = updates.tags as string[];
(updatedItem as any).tags = newTags;
}
// Handle knowledge_type updates
if ('knowledge_type' in updates && typeof updates.knowledge_type === 'string') {
const newType = updates.knowledge_type as "technical" | "business";
updatedItem.knowledge_type = newType;
}
// Synchronize metadata with top-level fields
updatedItem.metadata = {
...currentMetadata,
...((updatedItem as any).tags && { tags: (updatedItem as any).tags }),
...(updatedItem.knowledge_type && { knowledge_type: updatedItem.knowledge_type }),
};
queryClient.setQueryData<KnowledgeItem>(knowledgeKeys.detail(sourceId), updatedItem);
}
// Optimistically update summaries cache
queryClient.setQueriesData({ queryKey: knowledgeKeys.summary() }, (old: any) => {
queryClient.setQueriesData<KnowledgeItemsResponse>({ queryKey: knowledgeKeys.summary() }, (old) => {
if (!old?.items) return old;
return {
...old,
items: old.items.map((item: any) => {
items: old.items.map((item) => {
if (item.source_id === sourceId) {
const updatedItem = { ...item };
if ('tags' in updates) {
// Initialize metadata if missing
const currentMetadata = updatedItem.metadata || {};
// Update title if provided
if ('title' in updates && typeof updates.title === 'string') {
updatedItem.title = updates.title;
}
// Update tags if provided
if ('tags' in updates && Array.isArray(updates.tags)) {
const newTags = updates.tags as string[];
// Update both top-level tags and metadata.tags for consistency with summary API
updatedItem.tags = newTags;
updatedItem.metadata = { ...updatedItem.metadata, tags: newTags };
}
if ('knowledge_type' in updates) {
const newType = updates.knowledge_type as string;
// Update both top-level knowledge_type and metadata.knowledge_type for consistency
updatedItem.knowledge_type = newType as "technical" | "business";
updatedItem.metadata = { ...updatedItem.metadata, knowledge_type: newType };
// Update knowledge_type if provided
if ('knowledge_type' in updates && typeof updates.knowledge_type === 'string') {
const newType = updates.knowledge_type as "technical" | "business";
updatedItem.knowledge_type = newType;
}
// Synchronize metadata with top-level fields
updatedItem.metadata = {
...currentMetadata,
...(updatedItem.tags && { tags: updatedItem.tags }),
...(updatedItem.knowledge_type && { knowledge_type: updatedItem.knowledge_type }),
};
return updatedItem;
}
return item;