fix: Remove duplicate error toast notifications

- Remove duplicate showToast call from KnowledgeCardType catch block
- useUpdateKnowledgeItem mutation already handles error toasts in onError
- Use finally block to ensure editing state is cleared regardless of outcome
- Remove unused useToast import

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

archon-ui-main/src/features/knowledge/components/KnowledgeCardType.tsx

@@ -8,7 +8,6 @@ import { useEffect, useRef, useState } from "react";
 import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "../../ui/primitives";
 import { cn } from "../../ui/primitives/styles";
 import { SimpleTooltip } from "../../ui/primitives/tooltip";
-import { useToast } from "../../ui/hooks/useToast";
 import { useUpdateKnowledgeItem } from "../hooks";
 
 interface KnowledgeCardTypeProps {
@@ -23,7 +22,6 @@ export const KnowledgeCardType: React.FC<KnowledgeCardTypeProps> = ({
   const [isEditing, setIsEditing] = useState(false);
   const selectRef = useRef<HTMLDivElement>(null);
   const updateMutation = useUpdateKnowledgeItem();
-  const { showToast } = useToast();
 
   // Handle click outside to cancel editing
   useEffect(() => {
@@ -62,11 +60,9 @@ export const KnowledgeCardType: React.FC<KnowledgeCardTypeProps> = ({
           knowledge_type: newType,
         },
       });
-      setIsEditing(false);
-    } catch (error) {
-      // Show user-facing error toast with detailed message
-      const errorMessage = error instanceof Error ? error.message : "Update failed";
-      showToast(`Failed to update knowledge type: ${errorMessage}`, "error");
+    } finally {
+      // Always exit editing mode regardless of success or failure
+      // The mutation's onError handler will show error toasts if needed
       setIsEditing(false);
     }
   };