From d4dc4a30b8053865d041918c1c4bea2e74a5c29f Mon Sep 17 00:00:00 2001
From: vabene1111 <vabene1234@googlemail.com>
Date: Sat, 23 Nov 2024 13:26:12 +0100
Subject: [PATCH] fixed system page

---
 cookbook/templates/system.html |  4 +--
 cookbook/views/api.py          | 49 ++++++++++++++++++----------------
 cookbook/views/views.py        |  2 ++
 3 files changed, 30 insertions(+), 25 deletions(-)

diff --git a/cookbook/templates/system.html b/cookbook/templates/system.html
index ca7bd6252..e3b7d2024 100644
--- a/cookbook/templates/system.html
+++ b/cookbook/templates/system.html
@@ -175,7 +175,7 @@
     {#{% for orphan in orphans %}{{ orphan }}#}
     {#{% endfor %}#}
     {#    </textarea>#}
-
+    {% if api_space_stats %}
     <h4 class="mt-3">API Stats</h4>
     <h6 >Space Stats</h6>
     <table class="table table-bordered table-striped">
@@ -202,7 +202,7 @@
             </tr>
         {% endfor %}
     </table>
-
+    {% endif %}
     <h4 class="mt-3">Debug</h4>
     <textarea class="form-control" rows="20">
 Gunicorn Media: {{ gunicorn_media }}
diff --git a/cookbook/views/api.py b/cookbook/views/api.py
index 972180a7c..003e7b9bd 100644
--- a/cookbook/views/api.py
+++ b/cookbook/views/api.py
@@ -112,35 +112,38 @@ class LoggingMixin(object):
         super(LoggingMixin, self).initial(request, *args, **kwargs)
 
         if settings.REDIS_HOST:
-            d = date.today().isoformat()
-            space = request.space
-            endpoint = request.resolver_match.url_name
+            try:
+                d = date.today().isoformat()
+                space = request.space
+                endpoint = request.resolver_match.url_name
 
-            r = redis.StrictRedis(
-                host=settings.REDIS_HOST,
-                port=settings.REDIS_PORT,
-                username=settings.REDIS_USERNAME,
-                password=settings.REDIS_PASSWORD,
-                db=settings.REDIS_DATABASES['STATS'],
-            )
+                r = redis.StrictRedis(
+                    host=settings.REDIS_HOST,
+                    port=settings.REDIS_PORT,
+                    username=settings.REDIS_USERNAME,
+                    password=settings.REDIS_PASSWORD,
+                    db=settings.REDIS_DATABASES['STATS'],
+                )
 
-            pipe = r.pipeline()
+                pipe = r.pipeline()
 
-            # Global and daily tallies for all URLs.
-            pipe.incr('api:request-count')
-            pipe.incr(f'api:request-count:{d}')
+                # Global and daily tallies for all URLs.
+                pipe.incr('api:request-count')
+                pipe.incr(f'api:request-count:{d}')
 
-            # Use a sorted set to store the user stats, with the score representing
-            # the number of queries the user made total or on a given day.
-            pipe.zincrby(f'api:space-request-count', 1, space.pk)
-            pipe.zincrby(f'api:space-request-count:{d}', 1, space.pk)
+                # Use a sorted set to store the user stats, with the score representing
+                # the number of queries the user made total or on a given day.
+                pipe.zincrby(f'api:space-request-count', 1, space.pk)
+                pipe.zincrby(f'api:space-request-count:{d}', 1, space.pk)
 
-            # Use a sorted set to store all the endpoints with score representing
-            # the number of queries the endpoint received total or on a given day.
-            pipe.zincrby(f'api:endpoint-request-count', 1, endpoint)
-            pipe.zincrby(f'api:endpoint-request-count:{d}', 1, endpoint)
+                # Use a sorted set to store all the endpoints with score representing
+                # the number of queries the endpoint received total or on a given day.
+                pipe.zincrby(f'api:endpoint-request-count', 1, endpoint)
+                pipe.zincrby(f'api:endpoint-request-count:{d}', 1, endpoint)
 
-            pipe.execute()
+                pipe.execute()
+            except:
+                pass
 
 
 class StandardFilterMixin(ViewSetMixin):
diff --git a/cookbook/views/views.py b/cookbook/views/views.py
index 16da7e261..29066b1b6 100644
--- a/cookbook/views/views.py
+++ b/cookbook/views/views.py
@@ -346,6 +346,8 @@ def system(request):
     for key in migration_info.keys():
         migration_info[key]['total'] = len(migration_info[key]['unapplied_migrations']) + len(migration_info[key]['applied_migrations'])
 
+    api_stats = None
+    api_space_stats = None
     # API endpoint logging
     if settings.REDIS_HOST:
         r = redis.StrictRedis(