From 312c3647975455f163482b26c530b635e7d7bbed Mon Sep 17 00:00:00 2001 From: vabene1111 Date: Tue, 22 Sep 2020 12:19:30 +0200 Subject: [PATCH] fixed wrongly changed permission check order --- cookbook/helper/permission_helper.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cookbook/helper/permission_helper.py b/cookbook/helper/permission_helper.py index b9a9c98f7..6ff5be087 100644 --- a/cookbook/helper/permission_helper.py +++ b/cookbook/helper/permission_helper.py @@ -61,14 +61,14 @@ def is_object_owner(user, obj): # TODO this could be improved/cleaned up by adding get_owner methods to all models that allow owner checks if not user.is_authenticated: return False + if user.is_superuser: + return True if owner := getattr(obj, 'created_by', None): return owner == user if owner := getattr(obj, 'user', None): return owner == user if getattr(obj, 'get_owner', None): return obj.get_owner() == user - if user.is_superuser: - return True return False