From 39b69bf55093693a7d5097d4a1e5fee3c59010c3 Mon Sep 17 00:00:00 2001
From: samanhappy <samanhappy@gmail.com>
Date: Wed, 28 May 2025 14:30:35 +0800
Subject: [PATCH] fix: improve sessionId validation and error handling in
 handleSseMessage (#134)

---
 src/services/sseService.ts | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/src/services/sseService.ts b/src/services/sseService.ts
index 6294300..67cb595 100644
--- a/src/services/sseService.ts
+++ b/src/services/sseService.ts
@@ -81,16 +81,28 @@ export const handleSseMessage = async (req: Request, res: Response): Promise<voi
   }
 
   const sessionId = req.query.sessionId as string;
-  const { transport, group } = transports[sessionId];
+
+  // Validate sessionId
+  if (!sessionId) {
+    console.error('Missing sessionId in query parameters');
+    res.status(400).send('Missing sessionId parameter');
+    return;
+  }
+
+  // Check if transport exists before destructuring
+  const transportData = transports[sessionId];
+  if (!transportData) {
+    console.warn(`No transport found for sessionId: ${sessionId}`);
+    res.status(400).send('No transport found for sessionId');
+    return;
+  }
+
+  const { transport, group } = transportData;
   req.params.group = group;
   req.query.group = group;
   console.log(`Received message for sessionId: ${sessionId} in group: ${group}`);
-  if (transport) {
-    await (transport as SSEServerTransport).handlePostMessage(req, res);
-  } else {
-    console.error(`No transport found for sessionId: ${sessionId}`);
-    res.status(400).send('No transport found for sessionId');
-  }
+
+  await (transport as SSEServerTransport).handlePostMessage(req, res);
 };
 
 export const handleMcpPostRequest = async (req: Request, res: Response): Promise<void> => {