From 59c22ccc089c960b523ccfb69efc680b2687c353 Mon Sep 17 00:00:00 2001 From: Gauthier Date: Sun, 22 Dec 2024 05:56:22 +0100 Subject: [PATCH] fix(requestlist): use default value of sort direction only if valid (#1174) The Sort Direction was loaded with values from the localStorage, but `undefined` was assigned if no previous Sort Direction existed, causing the client to send undefined as a string for the Sort Direction. fix #1147 --- overseerr-api.yml | 1 + src/components/RequestList/index.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/overseerr-api.yml b/overseerr-api.yml index ac76f6a7e..9378d8db9 100644 --- a/overseerr-api.yml +++ b/overseerr-api.yml @@ -5448,6 +5448,7 @@ paths: schema: type: string enum: [asc, desc] + nullable: true default: desc - in: query name: requestedBy diff --git a/src/components/RequestList/index.tsx b/src/components/RequestList/index.tsx index 2a07059ff..1dba8c0a8 100644 --- a/src/components/RequestList/index.tsx +++ b/src/components/RequestList/index.tsx @@ -87,8 +87,10 @@ const RequestList = () => { setCurrentFilter(filterSettings.currentFilter); setCurrentSort(filterSettings.currentSort); - setCurrentSortDirection(filterSettings.currentSortDirection); setCurrentPageSize(filterSettings.currentPageSize); + if (['asc', 'desc'].includes(filterSettings.currentSortDirection)) { + setCurrentSortDirection(filterSettings.currentSortDirection); + } } // If filter value is provided in query, use that instead