From 1c6f5362d773c850a5e58b5013f0d65474467e9c Mon Sep 17 00:00:00 2001
From: Fallenbagel <98979876+Fallenbagel@users.noreply.github.com>
Date: Tue, 14 Jan 2025 19:01:42 +0800
Subject: [PATCH] fix(settingsmigrator): prevent region migration from running
 multiple times (#1255)

Adds a guard clause to skip region migration if discoverRegion and
streamingRegion properties already exist in settings. This prevents
accidental overwrites of existing region settings during multiple runs
and ensures the migration only executes when needed.

Previously, the migration would run every time regardless of whether the
new region properties existed, potentially overwriting user preferences.

fix #1251
---
 .../lib/settings/migrations/0004_migrate_region_setting.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/server/lib/settings/migrations/0004_migrate_region_setting.ts b/server/lib/settings/migrations/0004_migrate_region_setting.ts
index 2039e6fc9..a140e0781 100644
--- a/server/lib/settings/migrations/0004_migrate_region_setting.ts
+++ b/server/lib/settings/migrations/0004_migrate_region_setting.ts
@@ -1,6 +1,13 @@
 import type { AllSettings } from '@server/lib/settings';
 
 const migrateRegionSetting = (settings: any): AllSettings => {
+  if (
+    settings.main.discoverRegion !== undefined &&
+    settings.main.streamingRegion !== undefined
+  ) {
+    return settings;
+  }
+
   const oldRegion = settings.main.region;
   if (oldRegion) {
     settings.main.discoverRegion = oldRegion;