mirror of https://github.com/coleam00/Archon.git synced 2025-12-23 18:29:18 -05:00

Files

Rasmus Widing fd81505908 refactor: simplify workflow to user-selectable 6-command architecture

Simplifies the workflow orchestrator from hardcoded 11-step atomic operations
to user-selectable 6-command workflow with context passing.

Core changes:
- WorkflowStep enum: 11 steps → 6 commands (create-branch, planning, execute, commit, create-pr, prp-review)
- workflow_orchestrator.py: 367 lines → 200 lines with command stitching loop
- Remove workflow_type field, add selected_commands parameter
- Simplify agent names from 11 → 6 constants
- Remove test/review phase config flags (now optional commands)

Deletions:
- Remove test_workflow.py, review_workflow.py, workflow_phase_tracker.py
- Remove 32 old command files from .claude/commands
- Remove PRPs/specs and PRD files from version control
- Update .gitignore to exclude specs, features, and validation markdown files

Breaking changes:
- AgentWorkOrder no longer has workflow_type field
- CreateAgentWorkOrderRequest now uses selected_commands instead of workflow_type
- WorkflowStep enum values incompatible with old step history

56 files changed, 625 insertions(+), 15,007 deletions(-)

2025-10-16 19:18:32 +03:00

3.1 KiB

Raw Blame History

Code Review

Review implemented work against a PRP specification to ensure code quality, correctness, and adherence to project standards.

Variables

Plan file: $ARGUMENTS (e.g., PRPs/features/add-web-search.md)

Instructions

Understand the Changes:

Check current branch: git branch
Review changes: git diff origin/main (or git diff HEAD if not on a branch)
Read the PRP plan file to understand requirements

Code Quality Review:

Type Safety: Verify all functions have type annotations, mypy passes
Logging: Check structured logging is used correctly (event names, context, exception handling)
Docstrings: Ensure Google-style docstrings on all functions/classes
Testing: Verify unit tests exist for all new files, integration tests if needed
Architecture: Confirm vertical slice structure is followed
CLAUDE.md Compliance: Check adherence to core principles (KISS, YAGNI, TYPE SAFETY)

Validation Ruff for BE and Biome for FE:

Run linters: uv run ruff check src/ && uv run mypy src/
Run tests: uv run pytest tests/ -v
Start server and test endpoints with curl (if applicable)
Verify structured logs show proper correlation IDs and context

Issue Severity:

blocker - Must fix before merge (breaks build, missing tests, type errors, security issues)
major - Should fix (missing logging, incomplete docstrings, poor patterns)
minor - Nice to have (style improvements, optimization opportunities)

Report

Return ONLY valid JSON (no markdown, no explanations) save to [report-#.json] in prps/reports directory create the directory if it doesn't exist. Output will be parsed with JSON.parse().

Output Structure

{
  "success": "boolean - true if NO BLOCKER issues, false if BLOCKER issues exist",
  "review_summary": "string - 2-4 sentences: what was built, does it match spec, quality assessment",
  "review_issues": [
    {
      "issue_number": "number - issue index",
      "file_path": "string - file with the issue (if applicable)",
      "issue_description": "string - what's wrong",
      "issue_resolution": "string - how to fix it",
      "severity": "string - blocker|major|minor"
    }
  ],
  "validation_results": {
    "linting_passed": "boolean",
    "type_checking_passed": "boolean",
    "tests_passed": "boolean",
    "api_endpoints_tested": "boolean - true if endpoints were tested with curl"
  }
}

Example Success Review

{
  "success": true,
  "review_summary": "The web search tool has been implemented with proper type annotations, structured logging, and comprehensive tests. The implementation follows the vertical slice architecture and matches all spec requirements. Code quality is high with proper error handling and documentation.",
  "review_issues": [
    {
      "issue_number": 1,
      "file_path": "src/tools/web_search/tool.py",
      "issue_description": "Missing debug log for API response",
      "issue_resolution": "Add logger.debug with response metadata",
      "severity": "minor"
    }
  ],
  "validation_results": {
    "linting_passed": true,
    "type_checking_passed": true,
    "tests_passed": true,
    "api_endpoints_tested": true
  }
}

3.1 KiB Raw Blame History