mirror of https://github.com/coleam00/Archon.git synced 2025-12-23 18:29:18 -05:00

Files

Rasmus Widing 1c0020946b feat: Implement phases 3-5 of compositional workflow architecture

Completes the implementation of test/review workflows with automatic resolution
and integrates them into the orchestrator.

**Phase 3: Test Workflow with Resolution**
- Created test_workflow.py with automatic test failure resolution
- Implements retry loop with max 4 attempts (configurable via MAX_TEST_RETRY_ATTEMPTS)
- Parses JSON test results and resolves failures one by one
- Uses existing test.md and resolve_failed_test.md commands
- Added run_tests() and resolve_test_failure() to workflow_operations.py

**Phase 4: Review Workflow with Resolution**
- Created review_workflow.py with automatic blocker issue resolution
- Implements retry loop with max 3 attempts (configurable via MAX_REVIEW_RETRY_ATTEMPTS)
- Categorizes issues by severity (blocker/tech_debt/skippable)
- Only blocks on blocker issues - tech_debt and skippable allowed to pass
- Created review_runner.md and resolve_failed_review.md commands
- Added run_review() and resolve_review_issue() to workflow_operations.py
- Supports screenshot capture for UI review (configurable via ENABLE_SCREENSHOT_CAPTURE)

**Phase 5: Compositional Integration**
- Updated workflow_orchestrator.py to integrate test and review phases
- Test phase runs between commit and PR creation (if ENABLE_TEST_PHASE=true)
- Review phase runs after tests (if ENABLE_REVIEW_PHASE=true)
- Both phases are optional and controlled by config flags
- Step history tracks test and review execution results
- Proper error handling and logging for all phases

**Supporting Changes**
- Updated agent_names.py to add REVIEWER constant
- Added configuration flags to config.py for test/review phases
- All new code follows structured logging patterns
- Maintains compatibility with existing workflow steps

**Files Changed**: 19 files, 3035+ lines
- New: test_workflow.py, review_workflow.py, review commands
- Modified: orchestrator, workflow_operations, agent_names, config
- Phases 1-2 files (worktree, state, port allocation) also staged

The implementation is complete and ready for testing. All phases now support
parallel execution via worktree isolation with deterministic port allocation.

2025-10-16 19:18:03 +03:00

1.3 KiB

Raw Blame History

Resolve Failed Review Issue

Fix a specific blocker issue identified during the review phase.

Arguments

review_issue_json: JSON string containing the review issue to fix

Instructions

Parse Review Issue
- Extract issue_title, issue_description, issue_severity, and affected_files from the JSON
- Ensure this is a "blocker" severity issue (tech_debt and skippable are not resolved here)
Understand the Issue
- Read the issue description carefully
- Review the affected files listed
- If a spec file was referenced in the original review, re-read relevant sections
Create Fix Plan
- Determine what changes are needed to resolve the issue
- Identify all files that need to be modified
- Plan minimal, targeted changes
Implement the Fix
- Make only the changes necessary to resolve this specific issue
- Ensure code quality and consistency
- Follow project conventions and patterns
- Do not make unrelated changes
Verify the Fix
- Re-run relevant tests if applicable
- Check that the issue is actually resolved
- Ensure no new issues were introduced

Review Issue Input

$ARGUMENT_1

Report

Provide a concise summary of:

Root cause of the blocker issue
Specific changes made to resolve it
Files modified
Confirmation that the issue is resolved

1.3 KiB Raw Blame History