From 70b6e70a95f596f64e3517575e0abfbf88f2f1f8 Mon Sep 17 00:00:00 2001 From: sean-eskerium Date: Thu, 9 Oct 2025 07:59:54 -0400 Subject: [PATCH] trying to make the ui reviews programmatic --- .../archon/archon-ui-consistency-review.md | 168 ++++-- .../TAILWIND_RESPONSIVE_BEST_PRACTICES.md | 489 ++++++++++++++++++ .../configurators/ToggleConfigurator.tsx | 105 ++-- .../layouts/KnowledgeLayoutExample.tsx | 108 ++-- .../layouts/ProjectsLayoutExample.tsx | 138 +++-- .../style-guide/shared/ConfigPanel.tsx | 2 +- .../style-guide/showcases/StaticEffects.tsx | 24 +- .../style-guide/showcases/StaticTables.tsx | 56 +- .../features/ui/primitives/grouped-card.tsx | 79 +++ .../src/features/ui/primitives/index.ts | 1 + 10 files changed, 1013 insertions(+), 157 deletions(-) create mode 100644 PRPs/ai_docs/TAILWIND_RESPONSIVE_BEST_PRACTICES.md create mode 100644 archon-ui-main/src/features/ui/primitives/grouped-card.tsx diff --git a/.claude/commands/archon/archon-ui-consistency-review.md b/.claude/commands/archon/archon-ui-consistency-review.md index 4a88e128..b0625f01 100644 --- a/.claude/commands/archon/archon-ui-consistency-review.md +++ b/.claude/commands/archon/archon-ui-consistency-review.md @@ -283,102 +283,204 @@ Based on the argument: Use grep/glob to find: ```bash +# CRITICAL: Dynamic Tailwind class construction (WILL NOT WORK) +grep -r "bg-\${.*}\|text-\${.*}\|border-\${.*}\|shadow-\${.*}" [path] --include="*.tsx" +grep -r "\`bg-.*-.*\`\|\`text-.*-.*\`\|\`border-.*-.*\`" [path] --include="*.tsx" + +# CRITICAL: Unconstrained horizontal scroll (BREAKS LAYOUT) +grep -r "overflow-x-auto" [path] --include="*.tsx" | grep -v "w-full" + +# CRITICAL: min-w-max without parent width constraint +grep -r "min-w-max" [path] --include="*.tsx" + +# Non-responsive grids (BREAKS MOBILE) +grep -r "grid-cols-[2-9]" [path] --include="*.tsx" | grep -v "md:\|lg:\|sm:\|xl:" + +# Fixed widths without max-width constraints +grep -r "w-\[0-9\]\|w-96\|w-80\|w-72" [path] --include="*.tsx" | grep -v "max-w-" + # Hardcoded edge-lit implementations (should use Card primitive) -grep -r "absolute inset-x-0 top-0" [path] +grep -r "absolute inset-x-0 top-0.*bg-gradient-to-b" [path] --include="*.tsx" # Native HTML form elements (should use Radix) -grep -r "\|